Autofill deprecate unique_ids in favor of guids for PersonalDataManager

Final round of unique_id deprecation.  These changes migrated web_database schemas for profiles and credit cards, clean up the web_dataservice interface, bring the personal_data_manager interface inline with the GUID interfaces for web_dataservice, convert remaining unit tests to be GUID-based, and some changes to platform UI code that used unique IDs for edits.

BUG=58813
TEST=WebDataServiceTest.*, WebDatabaseTest.*, WebDatabaseMigrationTest.*, PersonalDataManagerTest.*, AutoFillTest.*, AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillProfileTest.MergeWith, ProfileSyncServiceAutofillTest.*, TwoClientLiveAutofillSyncTest.*

Review URL: http://codereview.chromium.org/4388001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65100 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 22 deletions

diff --git a/chrome/browser/webdata/web_database.h b/chrome/browser/webdata/web_database.h
index e7fd295..2d80437 100644
--- a/chrome/browser/webdata/web_database.h
+++ b/chrome/browser/webdata/web_database.h
@@ -226,21 +226,10 @@ class WebDatabase {
   // Updates the database values for the specified profile.
   virtual bool UpdateAutoFillProfile(const AutoFillProfile& profile);
 
-  // Removes a row from the autofill_profiles table.  |profile_id| is the
-  // unique ID of the profile to remove.
-  // DEPRECATED: In favor of |RemoveAutoFillProfile(const std::string& guid)|.
-  // TODO(dhollowa): Remove unique IDs.  http://crbug.com/58813
-  virtual bool RemoveAutoFillProfile(int profile_id);
-
   // Removes a row from the autofill_profiles table.  |guid| is the identifier
   // of the profile to remove.
   virtual bool RemoveAutoFillProfile(const std::string& guid);
 
-  // Retrieves profile for unique id |profile_id|, owned by caller.
-  // DEPRECATED: In favor of |GetAutoFillProfileForGUID(...)|.
-  // TODO(dhollowa): Remove unique IDs.  http://crbug.com/58813
-  bool GetAutoFillProfileForID(int profile_id, AutoFillProfile** profile);
-
   // Retrieves a profile with label |label|.  The caller owns |profile|.
   // DEPRECATED: In favor of |GetAutoFillProfileForGUID(...)|.
   // TODO(dhollowa): Remove labels.  http://crbug.com/58813
@@ -260,12 +249,6 @@ class WebDatabase {
   // Updates the database values for the specified credit card.
   bool UpdateCreditCard(const CreditCard& credit_card);
 
-  // Removes a row from the credit_cards table.  |credit_card_id| is the
-  // unique ID of the credit card to remove.
-  // DEPRECATED: In favor of |RemoveCreditCard(const std::string& guid)|.
-  // TODO(dhollowa): Remove unique IDs.  http://crbug.com/58813
-  bool RemoveCreditCard(int credit_card_id);
-
   // Removes a row from the credit_cards table.  |guid| is the identifer  of the
   // credit card to remove.
   bool RemoveCreditCard(const std::string& guid);
@@ -277,11 +260,6 @@ class WebDatabase {
   bool GetCreditCardForLabel(const string16& label,
                              CreditCard** credit_card);
 
-  // Retrieves credit card for a card with unique id |credit_card_id|.
-  // DEPRECATED: In favor of |GetCreditCardForGUID()|.
-  // TODO(dhollowa): Remove unique IDs.  http://crbug.com/58813
-  bool GetCreditCardForID(int credit_card_id, CreditCard** credit_card);
-
   // Retrieves a credit card with guid |guid|.  The caller owns
   // |credit_card_id|.
   bool GetCreditCardForGUID(const std::string& guid, CreditCard** credit_card);