summaryrefslogtreecommitdiffstats
path: root/chrome/browser/webdata
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-07 04:10:11 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-07 04:10:11 +0000
commite2ce1e0bbcc8f4336770a28107daff34a68514db (patch)
tree0a2a9e66f524f9354c4031f28fbbf99c33e152ae /chrome/browser/webdata
parent7e7fab44ba1068bdce201757e82b6650fbca455d (diff)
downloadchromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.zip
chromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.tar.gz
chromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.tar.bz2
Revert 65272 - Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed
[There is a lot of red on valgrind now... so trying a revert] An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself. BUG=61988 TEST=Memory bots stay green. Review URL: http://codereview.chromium.org/4612001 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/4641001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65329 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/webdata')
-rw-r--r--chrome/browser/webdata/web_data_service.cc2
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/browser/webdata/web_data_service.cc b/chrome/browser/webdata/web_data_service.cc
index d5ecd0f..d99fa73 100644
--- a/chrome/browser/webdata/web_data_service.cc
+++ b/chrome/browser/webdata/web_data_service.cc
@@ -1039,7 +1039,6 @@ void WebDataService::UpdateAutoFillProfileGUIDImpl(
// the caller will detect this on the next refresh.
AutoFillProfile* original_profile = NULL;
if (!db_->GetAutoFillProfileForGUID(profile.guid(), &original_profile)) {
- request->RequestComplete();
return;
}
scoped_ptr<AutoFillProfile> scoped_profile(original_profile);
@@ -1158,7 +1157,6 @@ void WebDataService::UpdateCreditCardGUIDImpl(
// the write and the caller will detect this on the next refresh.
CreditCard* original_credit_card = NULL;
if (!db_->GetCreditCardForGUID(credit_card.guid(), &original_credit_card)) {
- request->RequestComplete();
return;
}
scoped_ptr<CreditCard> scoped_credit_card(original_credit_card);