diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 01:03:33 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 01:03:33 +0000 |
| commit | d7b2a3fcfaadb7fb7fc1c01b8c491415d1234bf2 (patch) | |
| tree | 1b94035347c61dd171bcc6063e08d4e727ecc0f9 /chrome/browser/webdata | |
| parent | 0b1ad31e3a01a8b5698d8d30f04bd7ec1d2f00cb (diff) | |
| download | chromium_src-d7b2a3fcfaadb7fb7fc1c01b8c491415d1234bf2.zip chromium_src-d7b2a3fcfaadb7fb7fc1c01b8c491415d1234bf2.tar.gz chromium_src-d7b2a3fcfaadb7fb7fc1c01b8c491415d1234bf2.tar.bz2 | |
Don't DCHECK when clearing autofill data for EVERYTHING time period.
BUG=60184
TEST=unit_tests --gtest_filter=WebDatabaseTest.RemoveAutoFillProfilesAndCreditCardsModifiedBetween
Review URL: http://codereview.chromium.org/4064001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63464 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/webdata')
| -rw-r--r-- | chrome/browser/webdata/web_database.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/webdata/web_database_unittest.cc | 12 |
2 files changed, 12 insertions, 1 deletions
diff --git a/chrome/browser/webdata/web_database.cc b/chrome/browser/webdata/web_database.cc index 5fa538b..138fc7c2 100644 --- a/chrome/browser/webdata/web_database.cc +++ b/chrome/browser/webdata/web_database.cc @@ -1980,7 +1980,6 @@ bool WebDatabase::RemoveCreditCard(const std::string& guid) { bool WebDatabase::RemoveAutoFillProfilesAndCreditCardsModifiedBetween( base::Time delete_begin, base::Time delete_end) { - DCHECK(!delete_begin.is_null()); DCHECK(delete_end.is_null() || delete_begin < delete_end); time_t delete_begin_t = delete_begin.ToTimeT(); diff --git a/chrome/browser/webdata/web_database_unittest.cc b/chrome/browser/webdata/web_database_unittest.cc index 2f8c415..f9df633 100644 --- a/chrome/browser/webdata/web_database_unittest.cc +++ b/chrome/browser/webdata/web_database_unittest.cc @@ -1574,6 +1574,18 @@ TEST_F(WebDatabaseTest, RemoveAutoFillProfilesAndCreditCardsModifiedBetween) { ASSERT_TRUE(s_credit_cards_unbounded.Step()); EXPECT_EQ(47, s_credit_cards_unbounded.ColumnInt64(12)); EXPECT_FALSE(s_credit_cards_unbounded.Step()); + + // Remove all remaining entries. + db.RemoveAutoFillProfilesAndCreditCardsModifiedBetween(base::Time(), + base::Time()); + sql::Statement s_autofill_profiles_empty(db.db_.GetUniqueStatement( + "SELECT * FROM autofill_profiles")); + ASSERT_TRUE(s_autofill_profiles_empty); + EXPECT_FALSE(s_autofill_profiles_empty.Step()); + sql::Statement s_credit_cards_empty(db.db_.GetUniqueStatement( + "SELECT * FROM credit_cards")); + ASSERT_TRUE(s_credit_cards_empty); + EXPECT_FALSE(s_credit_cards_empty.Step()); } TEST_F(WebDatabaseTest, Autofill_GetAllAutofillEntries_NoResults) { |