diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 20:47:52 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 20:47:52 +0000 |
| commit | 4dad9ad838f6671fbd67e1c5292525e739e31983 (patch) | |
| tree | 4d79fc17f12752cc221e0e40d16951677da71f92 /chrome/browser/webdata | |
| parent | 2b3f0f59a6761a41e22007c2c3096e8e18517e08 (diff) | |
| download | chromium_src-4dad9ad838f6671fbd67e1c5292525e739e31983.zip chromium_src-4dad9ad838f6671fbd67e1c5292525e739e31983.tar.gz chromium_src-4dad9ad838f6671fbd67e1c5292525e739e31983.tar.bz2 | |
Many changes to DictionaryValues:
* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().
Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.
BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/webdata')
| -rw-r--r-- | chrome/browser/webdata/web_database_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/webdata/web_database_unittest.cc b/chrome/browser/webdata/web_database_unittest.cc index 4a54d76..beb716d 100644 --- a/chrome/browser/webdata/web_database_unittest.cc +++ b/chrome/browser/webdata/web_database_unittest.cc @@ -57,8 +57,8 @@ class WebDatabaseTest : public testing::Test { DictionaryValue::key_iterator e(a.end_keys()); std::wstring av, bv; while (i != e) { - if (!(a.GetString(*i, &av)) || - !(b.GetString(*i, &bv)) || + if (!(a.GetStringWithoutPathExpansion(*i, &av)) || + !(b.GetStringWithoutPathExpansion(*i, &bv)) || av != bv) return false; |