diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-31 22:52:27 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-31 22:52:27 +0000 |
| commit | 01428900d992d47476438f7343c504f528528ed5 (patch) | |
| tree | 69cf4c1cb52c1a82b806f769c7dfd91fc3719bc2 /chrome/browser | |
| parent | b1ccd3bdacc818a5160a029383ff7bfe7d10b3e4 (diff) | |
| download | chromium_src-01428900d992d47476438f7343c504f528528ed5.zip chromium_src-01428900d992d47476438f7343c504f528528ed5.tar.gz chromium_src-01428900d992d47476438f7343c504f528528ed5.tar.bz2 | |
GTTF: Remove possible interference between BlobURLRequestJob tests.
Quite a lot of state was shared between tests, like a temporary directory,
some paths, and a Thread (which could possibly have some tasks still running).
This is risky, and we had problems with those in the past. ui_tests used to
reuse the same temporary directory, which caused problems with file collisions
and failure to delete files.
We had problems with net_unittests having posted tasks after the test that
started them has finished. It is very hard to debug and reproduce when it happens.
This change increases the test run time by 3 ms (5 ms before vs 8 ms after).
Arguably, the time savings are not worth a possible reliability problem.
BUG=none
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/3281007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58085 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
0 files changed, 0 insertions, 0 deletions