summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authormbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-30 06:07:58 +0000
committermbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-30 06:07:58 +0000
commit4e6bc9f0a1c6ccf19cc7f31809d52c7b718d629b (patch)
tree57723f2357b4e654794428201593116628bf3797 /chrome/browser
parentc009fae449fffa030af4d2ceb0be85ecfbf38be0 (diff)
downloadchromium_src-4e6bc9f0a1c6ccf19cc7f31809d52c7b718d629b.zip
chromium_src-4e6bc9f0a1c6ccf19cc7f31809d52c7b718d629b.tar.gz
chromium_src-4e6bc9f0a1c6ccf19cc7f31809d52c7b718d629b.tar.bz2
Revert 57836 - Remove the SetBackground call during process creation. The benefit
of the call is that we de-prioritize work that is in the background. Unfortunately, tab creation currently bounces through hidden/unhidden/ hidden/unhidden at least 2x before the tab is visible to the user. Because we don't know if the tab will be in the foreground (and thus prevent it from being SetBackgrounded), the right thing to do is to simply not Background it on startup. I will test to see if this effects startup performance on the build bots. I wouldn't be surprised if it did, nor would I be surprised if it had no effect! NOTE: I'm uploading this as a test run through the performance bots. I will revert this change. BUG=21884 TEST=none Review URL: http://codereview.chromium.org/3288001 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/3263006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57837 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/renderer_host/browser_render_process_host.cc11
1 files changed, 2 insertions, 9 deletions
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc
index 83d59f0..0a27032 100644
--- a/chrome/browser/renderer_host/browser_render_process_host.cc
+++ b/chrome/browser/renderer_host/browser_render_process_host.cc
@@ -972,15 +972,8 @@ void BrowserRenderProcessHost::Observe(NotificationType type,
}
void BrowserRenderProcessHost::OnProcessLaunched() {
- // At this point, we used to set the process priority if it were marked as
- // backgrounded_. We don't do that anymore because when we create a process,
- // we really don't know how it will be used. If it is backgrounded, and not
- // yet processed, a stray hung-cpu process (not chrome) can cause pages to
- // not load at all. (see http://crbug.com/21884).
- // If we could perfectly track when a process is created as visible or not,
- // we could potentially call SetBackgrounded() properly at this point. But
- // there are many cases, and no effective way to automate those cases.
- // I'm choosing correctness over the feature of de-prioritizing this work.
+ // Now that the process is created, set its backgrounding accordingly.
+ SetBackgrounded(backgrounded_);
Send(new ViewMsg_SetIsIncognitoProcess(profile()->IsOffTheRecord()));