diff options
author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 19:33:30 +0000 |
---|---|---|
committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 19:33:30 +0000 |
commit | 2925996732c2dc5758708579da60f7656d630e05 (patch) | |
tree | 58901aaf0b5ce421c1f13b0f3835d094c5375602 /chrome/browser | |
parent | 90e76c6d9e254b1faec975adf097ff2d888840c0 (diff) | |
download | chromium_src-2925996732c2dc5758708579da60f7656d630e05.zip chromium_src-2925996732c2dc5758708579da60f7656d630e05.tar.gz chromium_src-2925996732c2dc5758708579da60f7656d630e05.tar.bz2 |
Make import from the options menu OOP on Mac OS X.
BUG=46701
TEST=import Firefox passwords from the menu once the browser is running. Because import is OOP, FF passwords should be imported. All other import processes should still work as advertised.
Review URL: http://codereview.chromium.org/2800026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50753 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r-- | chrome/browser/cocoa/import_settings_dialog.mm | 2 | ||||
-rw-r--r-- | chrome/browser/importer/importer.cc | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/import_settings_dialog.mm b/chrome/browser/cocoa/import_settings_dialog.mm index 77fb985..a11244a 100644 --- a/chrome/browser/cocoa/import_settings_dialog.mm +++ b/chrome/browser/cocoa/import_settings_dialog.mm @@ -179,7 +179,7 @@ bool importSettingsDialogVisible = false; int16 servicesToImport = static_cast<int16>(items & [self servicesToImport]); if (servicesToImport) { if (profile_) { - ImporterHost* importerHost = new ImporterHost; + ImporterHost* importerHost = new ExternalProcessImporterHost; // Note that a side effect of the following call is to cause the // importerHost to be disposed once the import has completed. StartImportingWithUI(nil, servicesToImport, importerHost, diff --git a/chrome/browser/importer/importer.cc b/chrome/browser/importer/importer.cc index 6c1ce32..fcb8f28 100644 --- a/chrome/browser/importer/importer.cc +++ b/chrome/browser/importer/importer.cc @@ -340,11 +340,12 @@ void ExternalProcessImporterHost::StartImportSettings( profile_info_ = &profile_info; items_ = items; + ImporterHost::AddRef(); // Balanced in ImporterHost::ImportEnded. + import_to_bookmark_bar_ = ShouldImportToBookmarkBar(first_run); CheckForFirefoxLock(profile_info, items, first_run); CheckForLoadedModels(items); - ImporterHost::AddRef(); // Balanced in ImporterHost::ImportEnded. InvokeTaskIfDone(); } |