diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-16 03:03:13 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-16 03:03:13 +0000 |
| commit | 5b0295eb2ff6dd988c2e3a340ad37e61fef0bbe3 (patch) | |
| tree | 2bdc41283bbdd0272426824edf5c6f65c0cf7d5e /chrome/browser | |
| parent | 71c64f6be0aa9b79c0243354106a5acb68b505d8 (diff) | |
| download | chromium_src-5b0295eb2ff6dd988c2e3a340ad37e61fef0bbe3.zip chromium_src-5b0295eb2ff6dd988c2e3a340ad37e61fef0bbe3.tar.gz chromium_src-5b0295eb2ff6dd988c2e3a340ad37e61fef0bbe3.tar.bz2 | |
Prevent crashes in QEMU by (correctly) saying no commands are enabled when there is no selected tab. This is significantly simpler than NULL checking all over the place since no one should call ExecuteCommand without first calling IsCommandEnabled.
TBR=sky
Review URL: http://codereview.chromium.org/10783
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5545 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/browser.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc index 7997348..142ef6f 100644 --- a/chrome/browser/browser.cc +++ b/chrome/browser/browser.cc @@ -288,6 +288,10 @@ bool Browser::SupportsCommand(int id) const { } bool Browser::IsCommandEnabled(int id) const { + // No commands are enabled if there is not yet any selected tab. + if (!GetSelectedTabContents()) + return false; + switch (id) { case IDC_BACK: return GetSelectedTabContents()->controller()->CanGoBack(); |