diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-12 19:57:16 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-12 19:57:16 +0000 |
| commit | 97d052416394e439380cb932dfaed867e9db650b (patch) | |
| tree | be6caff6c95a4294713bb26aecdb947b2fdb7c65 /chrome/browser | |
| parent | 0aa22e2feda12ca6a9e9f26a084a2307acfcc080 (diff) | |
| download | chromium_src-97d052416394e439380cb932dfaed867e9db650b.zip chromium_src-97d052416394e439380cb932dfaed867e9db650b.tar.gz chromium_src-97d052416394e439380cb932dfaed867e9db650b.tar.bz2 | |
Revert r41459:
"Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time."
Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup.
Review URL: http://codereview.chromium.org/871007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/browser_main_mac.mm | 2 | ||||
| -rw-r--r-- | chrome/browser/cocoa/extensions/extension_popup_controller.mm | 2 | ||||
| -rw-r--r-- | chrome/browser/cocoa/info_bubble_window.mm | 1 |
3 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/browser_main_mac.mm b/chrome/browser/browser_main_mac.mm index 2195761..7163618 100644 --- a/chrome/browser/browser_main_mac.mm +++ b/chrome/browser/browser_main_mac.mm @@ -61,11 +61,9 @@ void WillInitializeMainMessageLoop(const MainFunctionParams& parameters) { void DidEndMainMessageLoop() { AppController* appController = [NSApp delegate]; [appController didEndMainMessageLoop]; - LOG(ERROR) << "Notifying APP_TERMINATING."; NotificationService::current()->Notify(NotificationType::APP_TERMINATING, NotificationService::AllSources(), NotificationService::NoDetails()); - LOG(ERROR) << "Notified APP_TERMINATING."; } void RecordBreakpadStatusUMA(MetricsService* metrics) { diff --git a/chrome/browser/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/cocoa/extensions/extension_popup_controller.mm index 58a79e1..72271b5 100644 --- a/chrome/browser/cocoa/extensions/extension_popup_controller.mm +++ b/chrome/browser/cocoa/extensions/extension_popup_controller.mm @@ -6,7 +6,6 @@ #include <algorithm> -#include "base/logging.h" #include "chrome/browser/browser.h" #import "chrome/browser/cocoa/browser_window_cocoa.h" #import "chrome/browser/cocoa/extension_view_mac.h" @@ -92,7 +91,6 @@ CGFloat Clamp(CGFloat value, CGFloat min, CGFloat max) { } - (void)dealloc { - LOG(ERROR) << "Yep, I'm getting deleted."; [[NSNotificationCenter defaultCenter] removeObserver:self]; [super dealloc]; } diff --git a/chrome/browser/cocoa/info_bubble_window.mm b/chrome/browser/cocoa/info_bubble_window.mm index 7daa65a..0a65367 100644 --- a/chrome/browser/cocoa/info_bubble_window.mm +++ b/chrome/browser/cocoa/info_bubble_window.mm @@ -43,7 +43,6 @@ class AppNotificationBridge : public NotificationObserver { const NotificationDetails& details) { switch (type.value) { case NotificationType::APP_TERMINATING: - LOG(ERROR) << "Received notification."; [owner_ appIsTerminating]; break; default: |