Coverity: Fix a collection of uninitialized member variables, mostly in extensions code, but some random ones outside extensions code as well.

dhollowa  : issue 11558: render_view_host.cc
rafaelw   : issue 11055: extension_browser_event_router.cc
mirandac  : issue  9443: profile_import_thread.cc
estade    : issue  9321: info_bubble_gtk.cc
phajdan.jr: issue  8308: extensions_service_unittest.cc
phajdan.jr: issue  8309: extensions_service_unittest.cc
asargent  : issue  8307: extension_browsertest.cc
asargent  : issue  7610: extension_browser_actions_api.h
rafaelw   : issue  2289: extension_function.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2832070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53451 0039d316-1c4b-4281-b951-d872f2087c98

7 files changed, 23 insertions, 15 deletions

diff --git a/chrome/browser/extensions/extension_browser_actions_api.h b/chrome/browser/extensions/extension_browser_actions_api.h
index c958cb3..007d194 100644
--- a/chrome/browser/extensions/extension_browser_actions_api.h
+++ b/chrome/browser/extensions/extension_browser_actions_api.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -13,7 +13,10 @@ class ExtensionAction;
 // Base class for chrome.browserAction.* APIs.
 class BrowserActionFunction : public SyncExtensionFunction {
  protected:
-  BrowserActionFunction() : tab_id_(ExtensionAction::kDefaultTabId) {}
+  BrowserActionFunction()
+      : details_(NULL),
+        tab_id_(ExtensionAction::kDefaultTabId),
+        browser_action_(NULL) {}
   virtual ~BrowserActionFunction() {}
   virtual bool RunImpl();
   virtual bool RunBrowserAction() = 0;
diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc
index 62d1751..dedcc80 100644
--- a/chrome/browser/extensions/extension_browser_event_router.cc
+++ b/chrome/browser/extensions/extension_browser_event_router.cc
@@ -133,7 +133,8 @@ void ExtensionBrowserEventRouter::Init(Profile* profile) {
 
 ExtensionBrowserEventRouter::ExtensionBrowserEventRouter()
     : initialized_(false),
-      focused_window_id_(extension_misc::kUnknownWindowId) { }
+      focused_window_id_(extension_misc::kUnknownWindowId),
+      profile_(NULL) { }
 
 void ExtensionBrowserEventRouter::OnBrowserAdded(const Browser* browser) {
   RegisterForBrowserNotifications(browser);
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index d3494da..685034d 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -25,12 +25,11 @@
 #include "chrome/common/notification_type.h"
 #include "chrome/test/ui_test_utils.h"
 
-#if defined(OS_CHROMEOS)
-#include "chrome/common/chrome_switches.h"
-#endif
-
 ExtensionBrowserTest::ExtensionBrowserTest()
-    : target_page_action_count_(-1),
+    : loaded_(false),
+      installed_(false),
+      extension_installs_observed_(0),
+      target_page_action_count_(-1),
       target_visible_page_action_count_(-1) {
 }
 
@@ -58,7 +57,6 @@ void ExtensionBrowserTest::SetUpCommandLine(CommandLine* command_line) {
   command_line->AppendSwitchWithValue(switches::kLoginProfile, "user");
   command_line->AppendSwitch(switches::kNoFirstRun);
 #endif
-
 }
 
 bool ExtensionBrowserTest::LoadExtensionImpl(const FilePath& path,
diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc
index 6f5b100..50babe1 100644
--- a/chrome/browser/extensions/extension_function.cc
+++ b/chrome/browser/extensions/extension_function.cc
@@ -11,7 +11,10 @@
 #include "chrome/browser/profile.h"
 
 ExtensionFunction::ExtensionFunction()
-    : request_id_(-1), name_(""), has_callback_(false) {
+    : request_id_(-1),
+      profile_(NULL),
+      has_callback_(false),
+      include_incognito_(false) {
 }
 
 ExtensionFunction::~ExtensionFunction() {
diff --git a/chrome/browser/extensions/extensions_service_unittest.cc b/chrome/browser/extensions/extensions_service_unittest.cc
index c209f59..218e3dd 100644
--- a/chrome/browser/extensions/extensions_service_unittest.cc
+++ b/chrome/browser/extensions/extensions_service_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -210,7 +210,7 @@ class MockProviderVisitor : public ExternalExtensionProvider::Visitor {
 
 class ExtensionTestingProfile : public TestingProfile {
  public:
-  ExtensionTestingProfile() {
+  ExtensionTestingProfile() : service_(NULL) {
   }
 
   void set_extensions_service(ExtensionsService* service) {
@@ -224,7 +224,8 @@ class ExtensionTestingProfile : public TestingProfile {
 
 // Our message loop may be used in tests which require it to be an IO loop.
 ExtensionsServiceTestBase::ExtensionsServiceTestBase()
-    : loop_(MessageLoop::TYPE_IO),
+    : total_successes_(0),
+      loop_(MessageLoop::TYPE_IO),
       ui_thread_(ChromeThread::UI, &loop_),
       webkit_thread_(ChromeThread::WEBKIT, &loop_),
       file_thread_(ChromeThread::FILE, &loop_),
diff --git a/chrome/browser/gtk/info_bubble_gtk.cc b/chrome/browser/gtk/info_bubble_gtk.cc
index 3f155ea..1da8383 100644
--- a/chrome/browser/gtk/info_bubble_gtk.cc
+++ b/chrome/browser/gtk/info_bubble_gtk.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -65,6 +65,7 @@ InfoBubbleGtk::InfoBubbleGtk(GtkThemeProvider* provider,
       theme_provider_(provider),
       accel_group_(gtk_accel_group_new()),
       toplevel_window_(NULL),
+      anchor_widget_(NULL),
       mask_region_(NULL),
       preferred_arrow_location_(ARROW_LOCATION_TOP_LEFT),
       current_arrow_location_(ARROW_LOCATION_TOP_LEFT),
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc
index 074df8d..72e55b6 100644
--- a/chrome/browser/renderer_host/render_view_host.cc
+++ b/chrome/browser/renderer_host/render_view_host.cc
@@ -128,7 +128,8 @@ RenderViewHost::RenderViewHost(SiteInstance* instance,
       are_javascript_messages_suppressed_(false),
       sudden_termination_allowed_(false),
       session_storage_namespace_id_(session_storage_namespace_id),
-      is_extension_process_(false) {
+      is_extension_process_(false),
+      autofill_query_id_(0) {
   DCHECK(instance_);
   DCHECK(delegate_);
 }