summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-23 21:06:28 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-23 21:06:28 +0000
commitcb3f30178b2065ec440c6c840ea3c45d0bbeb61c (patch)
tree43527a2ffb1152e955e677611b459dcd79b18058 /chrome/browser
parent96c2e8ec18feb0766c22acfb481a59f0983c572a (diff)
downloadchromium_src-cb3f30178b2065ec440c6c840ea3c45d0bbeb61c.zip
chromium_src-cb3f30178b2065ec440c6c840ea3c45d0bbeb61c.tar.gz
chromium_src-cb3f30178b2065ec440c6c840ea3c45d0bbeb61c.tar.bz2
Gather more info when AutocompleteBrowserTest flakily fails.
It's most probably a bug in the code being tested, or a bad assumption in the test. TEST=none BUG=19876 Review URL: http://codereview.chromium.org/233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26981 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/autocomplete/autocomplete_browsertest.cc20
1 files changed, 18 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_browsertest.cc b/chrome/browser/autocomplete/autocomplete_browsertest.cc
index 379a076..7af31cb 100644
--- a/chrome/browser/autocomplete/autocomplete_browsertest.cc
+++ b/chrome/browser/autocomplete/autocomplete_browsertest.cc
@@ -14,6 +14,22 @@
#include "chrome/test/ui_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
+namespace {
+
+std::wstring AutocompleteResultAsString(const AutocompleteResult& result) {
+ std::wstring output(StringPrintf(L"{%d} ", result.size()));
+ for (size_t i = 0; i < result.size(); ++i) {
+ AutocompleteMatch match = result.match_at(i);
+ std::wstring provider_name(ASCIIToWide(match.provider->name()));
+ output.append(StringPrintf(L"[\"%ls\" by \"%ls\"] ",
+ match.contents.c_str(),
+ provider_name.c_str()));
+ }
+ return output;
+}
+
+} // namespace
+
class AutocompleteBrowserTest : public InProcessBrowserTest {
protected:
LocationBar* GetLocationBar() const {
@@ -77,7 +93,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, Autocomplete) {
EXPECT_EQ(std::wstring(), location_bar->location_entry()->GetText());
EXPECT_TRUE(location_bar->location_entry()->IsSelectAll());
const AutocompleteResult& result = autocomplete_controller->result();
- ASSERT_EQ(1U, result.size());
+ ASSERT_EQ(1U, result.size()) << AutocompleteResultAsString(result);
AutocompleteMatch match = result.match_at(0);
EXPECT_EQ(AutocompleteMatch::SEARCH_WHAT_YOU_TYPED, match.type);
EXPECT_FALSE(match.deletable);
@@ -91,6 +107,6 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, Autocomplete) {
location_bar->location_entry()->GetText());
EXPECT_FALSE(location_bar->location_entry()->IsSelectAll());
const AutocompleteResult& result = autocomplete_controller->result();
- EXPECT_TRUE(result.empty());
+ EXPECT_TRUE(result.empty()) << AutocompleteResultAsString(result);
}
}