diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-25 20:55:42 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-25 20:55:42 +0000 |
| commit | f2f7b4ad1909cdffae5c2c63595bd5bec8151dad (patch) | |
| tree | 7b8950e08956f10510be8a8cbbbcc5f1fa88ba4e /chrome/browser | |
| parent | c6629d5cebc2cbfac52f81fd88b9039df4281ac2 (diff) | |
| download | chromium_src-f2f7b4ad1909cdffae5c2c63595bd5bec8151dad.zip chromium_src-f2f7b4ad1909cdffae5c2c63595bd5bec8151dad.tar.gz chromium_src-f2f7b4ad1909cdffae5c2c63595bd5bec8151dad.tar.bz2 | |
Revert "Fix/punt on a bunch of NOTIMPLEMENTEDs."
This reverts commit r12489.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12492 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/gtk/browser_window_gtk.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_gtk.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/web_contents_view_gtk.cc | 14 |
3 files changed, 5 insertions, 15 deletions
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc index 813441b..e2960f8 100644 --- a/chrome/browser/gtk/browser_window_gtk.cc +++ b/chrome/browser/gtk/browser_window_gtk.cc @@ -364,9 +364,7 @@ void BrowserWindowGtk::UpdateLoadingAnimations(bool should_animate) { } void BrowserWindowGtk::SetStarredState(bool is_starred) { - // Hide our current lack of starring support from NOTIMPLEMENTED spew. - if (is_starred) - NOTIMPLEMENTED(); + NOTIMPLEMENTED(); } gfx::Rect BrowserWindowGtk::GetNormalBounds() const { diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc index 99067af..08c0d4f 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc @@ -196,7 +196,7 @@ void RenderWidgetHostViewGtk::WasHidden() { } void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) { - // We rely on our parent GTK container to size us. + NOTIMPLEMENTED(); } gfx::NativeView RenderWidgetHostViewGtk::GetPluginNativeView() { diff --git a/chrome/browser/tab_contents/web_contents_view_gtk.cc b/chrome/browser/tab_contents/web_contents_view_gtk.cc index ece1d35..5b7603a11 100644 --- a/chrome/browser/tab_contents/web_contents_view_gtk.cc +++ b/chrome/browser/tab_contents/web_contents_view_gtk.cc @@ -114,12 +114,7 @@ gfx::NativeWindow WebContentsViewGtk::GetTopLevelNativeWindow() const { } void WebContentsViewGtk::GetContainerBounds(gfx::Rect* out) const { - // This is used for positioning the download shelf arrow animation, - // as well as sizing some other widgets in Windows. In GTK the size is - // managed for us, so it appears to be only used for the download shelf - // animation. - out->SetRect(vbox_.get()->allocation.x, vbox_.get()->allocation.y, - vbox_.get()->allocation.width, vbox_.get()->allocation.height); + NOTIMPLEMENTED(); } void WebContentsViewGtk::OnContentsDestroy() { @@ -128,10 +123,7 @@ void WebContentsViewGtk::OnContentsDestroy() { } void WebContentsViewGtk::SetPageTitle(const std::wstring& title) { - // Set the window name to include the page title so it's easier to spot - // when debugging (e.g. via xwininfo -tree). - if (content_view_) - gdk_window_set_title(content_view_->window, WideToASCII(title).c_str()); + NOTIMPLEMENTED(); } void WebContentsViewGtk::Invalidate() { @@ -176,7 +168,7 @@ void WebContentsViewGtk::RestoreFocus() { // TODO(estade): implement this function. // For now just assume we are viewing the tab for the first time. SetInitialFocus(); - NOTIMPLEMENTED() << " -- need to restore the focus position on this page."; + NOTIMPLEMENTED(); } void WebContentsViewGtk::UpdateDragCursor(bool is_drop_target) { |
