summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-29 01:13:23 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-29 01:13:23 +0000
commit031e4d30e56ca9fc438e7e32bf6e51bdee74e8d0 (patch)
treefd9e8d470de5f79c0e531fecc1338ca6197974a7 /chrome/browser
parente76049f366a8ffd17708d8915d7d3881b35d53a4 (diff)
downloadchromium_src-031e4d30e56ca9fc438e7e32bf6e51bdee74e8d0.zip
chromium_src-031e4d30e56ca9fc438e7e32bf6e51bdee74e8d0.tar.gz
chromium_src-031e4d30e56ca9fc438e7e32bf6e51bdee74e8d0.tar.bz2
linux: reduce header interdependencies
By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/browser_theme_pack.cc1
-rw-r--r--chrome/browser/browser_theme_provider.cc1
-rw-r--r--chrome/browser/browser_theme_provider.h19
-rw-r--r--chrome/browser/browser_theme_provider_gtk.cc2
-rw-r--r--chrome/browser/dom_ui/dom_ui_theme_source.cc1
-rw-r--r--chrome/browser/dom_ui/ntp_resource_cache.cc1
-rw-r--r--chrome/browser/gtk/blocked_popup_container_view_gtk.cc1
-rw-r--r--chrome/browser/gtk/find_bar_gtk.cc1
-rw-r--r--chrome/browser/gtk/first_run_dialog.h3
-rw-r--r--chrome/browser/gtk/gtk_theme_provider.cc1
-rw-r--r--chrome/browser/renderer_host/render_widget_host_view_gtk.cc3
-rw-r--r--chrome/browser/views/detachable_toolbar_view.cc1
-rw-r--r--chrome/browser/views/find_bar_host.cc4
13 files changed, 28 insertions, 11 deletions
diff --git a/chrome/browser/browser_theme_pack.cc b/chrome/browser/browser_theme_pack.cc
index 638cca2..acfa24e 100644
--- a/chrome/browser/browser_theme_pack.cc
+++ b/chrome/browser/browser_theme_pack.cc
@@ -8,6 +8,7 @@
#include "app/gfx/codec/png_codec.h"
#include "app/gfx/skbitmap_operations.h"
+#include "app/resource_bundle.h"
#include "base/data_pack.h"
#include "base/logging.h"
#include "base/stl_util-inl.h"
diff --git a/chrome/browser/browser_theme_provider.cc b/chrome/browser/browser_theme_provider.cc
index ae08fa8..46bf290 100644
--- a/chrome/browser/browser_theme_provider.cc
+++ b/chrome/browser/browser_theme_provider.cc
@@ -6,6 +6,7 @@
#include "app/gfx/codec/png_codec.h"
#include "app/gfx/skbitmap_operations.h"
+#include "app/resource_bundle.h"
#include "base/file_util.h"
#include "base/stl_util-inl.h"
#include "base/string_util.h"
diff --git a/chrome/browser/browser_theme_provider.h b/chrome/browser/browser_theme_provider.h
index 756e2bc..1474c24 100644
--- a/chrome/browser/browser_theme_provider.h
+++ b/chrome/browser/browser_theme_provider.h
@@ -8,22 +8,23 @@
#include <map>
#include <set>
#include <string>
-#include <vector>
-#include "app/gfx/color_utils.h"
-#include "app/resource_bundle.h"
#include "app/theme_provider.h"
-#include "base/basictypes.h"
-#include "base/lock.h"
#include "base/non_thread_safe.h"
#include "base/ref_counted.h"
-class Extension;
-class Profile;
+namespace color_utils {
+ struct HSL;
+}
+
+class BrowserThemePack;
+class BrowserThemeProviderTest;
class DictionaryValue;
+class Extension;
+class FilePath;
class PrefService;
-class BrowserThemeProviderTest;
-class BrowserThemePack;
+class Profile;
+class ResourceBundle;
class BrowserThemeProvider : public NonThreadSafe,
public ThemeProvider {
diff --git a/chrome/browser/browser_theme_provider_gtk.cc b/chrome/browser/browser_theme_provider_gtk.cc
index 3269c15..c52a9fe 100644
--- a/chrome/browser/browser_theme_provider_gtk.cc
+++ b/chrome/browser/browser_theme_provider_gtk.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/browser_theme_provider.h"
+#include <gdk-pixbuf/gdk-pixbuf.h>
+
#include "app/gfx/gtk_util.h"
#include "app/l10n_util.h"
#include "base/logging.h"
diff --git a/chrome/browser/dom_ui/dom_ui_theme_source.cc b/chrome/browser/dom_ui/dom_ui_theme_source.cc
index c871e42..75de29d 100644
--- a/chrome/browser/dom_ui/dom_ui_theme_source.cc
+++ b/chrome/browser/dom_ui/dom_ui_theme_source.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/dom_ui/dom_ui_theme_source.h"
+#include "app/resource_bundle.h"
#include "app/theme_provider.h"
#include "base/message_loop.h"
#include "chrome/browser/browser_theme_provider.h"
diff --git a/chrome/browser/dom_ui/ntp_resource_cache.cc b/chrome/browser/dom_ui/ntp_resource_cache.cc
index 2cbb282..ac935aa 100644
--- a/chrome/browser/dom_ui/ntp_resource_cache.cc
+++ b/chrome/browser/dom_ui/ntp_resource_cache.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/dom_ui/ntp_resource_cache.h"
#include "app/animation.h"
+#include "app/gfx/color_utils.h"
#include "app/l10n_util.h"
#include "app/resource_bundle.h"
#include "app/theme_provider.h"
diff --git a/chrome/browser/gtk/blocked_popup_container_view_gtk.cc b/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
index d5341a7..bc4bb1c 100644
--- a/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
+++ b/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
@@ -6,6 +6,7 @@
#include "app/gfx/gtk_util.h"
#include "app/l10n_util.h"
+#include "app/resource_bundle.h"
#include "base/string_util.h"
#include "chrome/browser/gtk/custom_button.h"
#include "chrome/browser/gtk/gtk_chrome_button.h"
diff --git a/chrome/browser/gtk/find_bar_gtk.cc b/chrome/browser/gtk/find_bar_gtk.cc
index 0ee2137..fb2fa9b 100644
--- a/chrome/browser/gtk/find_bar_gtk.cc
+++ b/chrome/browser/gtk/find_bar_gtk.cc
@@ -8,6 +8,7 @@
#include "app/gfx/gtk_util.h"
#include "app/l10n_util.h"
+#include "app/resource_bundle.h"
#include "base/string_util.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/profile.h"
diff --git a/chrome/browser/gtk/first_run_dialog.h b/chrome/browser/gtk/first_run_dialog.h
index b0f7e61..fb77c87 100644
--- a/chrome/browser/gtk/first_run_dialog.h
+++ b/chrome/browser/gtk/first_run_dialog.h
@@ -5,7 +5,8 @@
#ifndef CHROME_BROWSER_GTK_FIRST_RUN_DIALOG_H_
#define CHROME_BROWSER_GTK_FIRST_RUN_DIALOG_H_
-#include <gtk/gtk.h>
+typedef struct _GtkButton GtkButton;
+typedef struct _GtkWidget GtkWidget;
#include "chrome/browser/first_run.h"
#include "chrome/browser/importer/importer.h"
diff --git a/chrome/browser/gtk/gtk_theme_provider.cc b/chrome/browser/gtk/gtk_theme_provider.cc
index 7881bae..971be0c 100644
--- a/chrome/browser/gtk/gtk_theme_provider.cc
+++ b/chrome/browser/gtk/gtk_theme_provider.cc
@@ -9,6 +9,7 @@
#include "app/gfx/color_utils.h"
#include "app/gfx/gtk_util.h"
#include "app/gfx/skbitmap_operations.h"
+#include "app/resource_bundle.h"
#include "base/stl_util-inl.h"
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/profile.h"
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
index 016a34a..f143b1d 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
@@ -673,7 +673,8 @@ void RenderWidgetHostViewGtk::ShowCurrentCursor() {
break;
default:
- gdk_cursor = gtk_util::GetCursor(current_cursor_.GetCursorType());
+ gdk_cursor = gtk_util::GetCursor(
+ static_cast<GdkCursorType>(current_cursor_.GetCursorType()));
}
gdk_window_set_cursor(view_.get()->window, gdk_cursor);
// The window now owns the cursor.
diff --git a/chrome/browser/views/detachable_toolbar_view.cc b/chrome/browser/views/detachable_toolbar_view.cc
index 0664d01..fcf8f5c 100644
--- a/chrome/browser/views/detachable_toolbar_view.cc
+++ b/chrome/browser/views/detachable_toolbar_view.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/views/detachable_toolbar_view.h"
#include "app/gfx/canvas.h"
+#include "app/resource_bundle.h"
#include "chrome/browser/browser_theme_provider.h"
#include "grit/theme_resources.h"
#include "skia/ext/skia_utils.h"
diff --git a/chrome/browser/views/find_bar_host.cc b/chrome/browser/views/find_bar_host.cc
index bc81cda..1e7cca7 100644
--- a/chrome/browser/views/find_bar_host.cc
+++ b/chrome/browser/views/find_bar_host.cc
@@ -23,6 +23,10 @@
#include "views/widget/root_view.h"
#include "views/widget/widget.h"
+#if defined(OS_LINUX)
+#include "app/scoped_handle_gtk.h"
+#endif
+
using gfx::Path;
namespace browser {