diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-08 23:14:39 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-08 23:14:39 +0000 |
| commit | 18beec52826496c4098e243afd64cba7d1fb0959 (patch) | |
| tree | 67a08bcbe5e1a42c7277d6b066dfab641db040ac /chrome/browser | |
| parent | 4a0765a6e06b2e188c68999a52b3fea976e72c40 (diff) | |
| download | chromium_src-18beec52826496c4098e243afd64cba7d1fb0959.zip chromium_src-18beec52826496c4098e243afd64cba7d1fb0959.tar.gz chromium_src-18beec52826496c4098e243afd64cba7d1fb0959.tar.bz2 | |
Stop leaking RenderWidgetHostViewGtk.
Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted.
This also fixes interstitial pages crashing. Although instead we have two RWHV widgets in the same TabContentsView vbox :) I'll fix that in a later changelist.
Also update the valgrind suppressions file.
BUG=http://www.crbug.com/10747
BUG=http://www.crbug.com/8486
Review URL: http://codereview.chromium.org/115145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15695 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_gtk.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/tab_contents_view_gtk.cc | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc index a31c70c..e737606 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc @@ -309,6 +309,7 @@ void RenderWidgetHostViewGtk::Destroy() { // does the right thing, automatically removing ourselves from our parent // container. view_.Destroy(); + delete this; } void RenderWidgetHostViewGtk::SetTooltipText(const std::wstring& tooltip_text) { diff --git a/chrome/browser/tab_contents/tab_contents_view_gtk.cc b/chrome/browser/tab_contents/tab_contents_view_gtk.cc index d132e28..4ef882b 100644 --- a/chrome/browser/tab_contents/tab_contents_view_gtk.cc +++ b/chrome/browser/tab_contents/tab_contents_view_gtk.cc @@ -109,7 +109,6 @@ RenderWidgetHostView* TabContentsViewGtk::CreateViewForWidget( GDK_POINTER_MOTION_MASK); g_signal_connect(content_view, "button-press-event", G_CALLBACK(OnMouseDown), this); - gfx::RemoveAllChildren(vbox_.get()); gtk_box_pack_start(GTK_BOX(vbox_.get()), content_view, TRUE, TRUE, 0); return view; } |