summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-22 21:23:37 +0000
committerpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-22 21:23:37 +0000
commit39c74921db1ccd9610216f970860ad401ce303cf (patch)
tree36a78ad9269dbcafed9827457512aca67e004617 /chrome/browser
parent5606708cc8d4d9160803563696f999c23089dcb6 (diff)
downloadchromium_src-39c74921db1ccd9610216f970860ad401ce303cf.zip
chromium_src-39c74921db1ccd9610216f970860ad401ce303cf.tar.gz
chromium_src-39c74921db1ccd9610216f970860ad401ce303cf.tar.bz2
Remove more TODOs that are un-necessary
BUG=none TEST=none Review URL: http://codereview.chromium.org/652047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39633 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/cocoa/tab_controller.h4
-rw-r--r--chrome/browser/cocoa/web_drop_target_unittest.mm5
-rw-r--r--chrome/browser/tab_contents/render_view_context_menu_mac.mm6
-rw-r--r--chrome/browser/tabs/tab_strip_model.h4
4 files changed, 3 insertions, 16 deletions
diff --git a/chrome/browser/cocoa/tab_controller.h b/chrome/browser/cocoa/tab_controller.h
index 75f51267..06d58c8 100644
--- a/chrome/browser/cocoa/tab_controller.h
+++ b/chrome/browser/cocoa/tab_controller.h
@@ -10,10 +10,6 @@
#include "chrome/browser/tab_menu_model.h"
// The loading/waiting state of the tab.
-// TODO(pinkerton): this really doesn't belong here, but something needs to
-// know the state and another parallel array in TabStripController doesn't seem
-// like the right place either. In a perfect world, this class shouldn't know
-// anything about states that are specific to a browser.
enum TabLoadingState {
kTabDone,
kTabLoading,
diff --git a/chrome/browser/cocoa/web_drop_target_unittest.mm b/chrome/browser/cocoa/web_drop_target_unittest.mm
index d5f6c47..3db4777 100644
--- a/chrome/browser/cocoa/web_drop_target_unittest.mm
+++ b/chrome/browser/cocoa/web_drop_target_unittest.mm
@@ -131,8 +131,3 @@ TEST_F(WebDropTargetTest, Data) {
[pboard releaseGlobally];
}
-
-TEST_F(WebDropTargetTest, EnterExitDrop) {
- // TODO(pinkerton): Call enter/exit/drop and see what happens. This is a bit
- // harder to test.
-}
diff --git a/chrome/browser/tab_contents/render_view_context_menu_mac.mm b/chrome/browser/tab_contents/render_view_context_menu_mac.mm
index 25cea42..e38cfdf 100644
--- a/chrome/browser/tab_contents/render_view_context_menu_mac.mm
+++ b/chrome/browser/tab_contents/render_view_context_menu_mac.mm
@@ -86,9 +86,9 @@ void RenderViewContextMenuMac::DoInit() {
}
}
-// Do things like remove the windows accelerators.
-// TODO(pinkerton): Do we want to do anything like make a maximum string width
-// and middle-truncate?
+// Do things like remove the windows accelerators. Since we control the
+// contents of this context menu, we don't need to worry about maximum string
+// lengths or middle-truncation.
NSString* RenderViewContextMenuMac::PrepareLabelForDisplay(
const string16& label) {
NSString* title = l10n_util::FixUpWindowsStyleLabel(label);
diff --git a/chrome/browser/tabs/tab_strip_model.h b/chrome/browser/tabs/tab_strip_model.h
index 8e3fa61..a4c3641 100644
--- a/chrome/browser/tabs/tab_strip_model.h
+++ b/chrome/browser/tabs/tab_strip_model.h
@@ -151,10 +151,6 @@ class TabStripModelDelegate {
// be docked as identified by |dock_info|. Returns the Browser object
// representing the newly created window and tab strip. This does not
// show the window, it's up to the caller to do so.
- // TODO(pinkerton): I really don't like the fact that this is returning a
- // Browser object, there may be some better abstraction we can achieve that
- // the Browser implements, but for now, we'll experiment with returning
- // that type.
virtual Browser* CreateNewStripWithContents(TabContents* contents,
const gfx::Rect& window_bounds,
const DockInfo& dock_info) = 0;