summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-13 10:29:07 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-13 10:29:07 +0000
commit5c2387504ee4124ce0521212d895bae87cf08d8f (patch)
tree3e9c3539afbd5cb96af547a012fd99ad4f1aecac /chrome/browser
parent94fe52ee5bdf2d2feaa771537164909250ec174f (diff)
downloadchromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.zip
chromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.tar.gz
chromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.tar.bz2
Reduce header dependencies in browser/
- remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/app_controller_mac.mm1
-rw-r--r--chrome/browser/autocomplete/search_provider_unittest.cc1
-rwxr-xr-xchrome/browser/automation/automation_provider.cc1
-rw-r--r--chrome/browser/automation/automation_provider_list.cc2
-rw-r--r--chrome/browser/bookmarks/bookmark_context_menu.cc2
-rw-r--r--chrome/browser/browser.cc24
-rw-r--r--chrome/browser/browser.h27
-rw-r--r--chrome/browser/browser_main.cc1
-rw-r--r--chrome/browser/browser_window.h6
-rw-r--r--chrome/browser/child_process_security_policy.h1
-rw-r--r--chrome/browser/chrome_plugin_host.cc1
-rw-r--r--chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm1
-rw-r--r--chrome/browser/cocoa/command_observer_bridge.mm2
-rw-r--r--chrome/browser/cocoa/preferences_window_controller.mm1
-rw-r--r--chrome/browser/command_updater.cc13
-rw-r--r--chrome/browser/command_updater.h11
-rw-r--r--chrome/browser/debugger/debugger_host.h4
-rw-r--r--chrome/browser/debugger/debugger_io.h1
-rw-r--r--chrome/browser/debugger/debugger_io_socket.cc1
-rw-r--r--chrome/browser/debugger/debugger_io_socket.h6
-rw-r--r--chrome/browser/debugger/debugger_remote_service.h1
-rw-r--r--chrome/browser/debugger/debugger_wrapper.h1
-rw-r--r--chrome/browser/debugger/devtools_client_host.h2
-rw-r--r--chrome/browser/debugger/devtools_remote_listen_socket.h1
-rw-r--r--chrome/browser/debugger/devtools_remote_message.h1
-rw-r--r--chrome/browser/debugger/devtools_sanity_unittest.cc1
-rw-r--r--chrome/browser/debugger/devtools_window.cc1
-rw-r--r--chrome/browser/dom_ui/debugger_ui.cc2
-rw-r--r--chrome/browser/dom_ui/dom_ui.h1
-rw-r--r--chrome/browser/dom_ui/downloads_dom_handler.cc3
-rw-r--r--chrome/browser/dom_ui/downloads_dom_handler.h4
-rw-r--r--chrome/browser/dom_ui/html_dialog_ui.h5
-rw-r--r--chrome/browser/encoding_menu_controller.cc2
-rw-r--r--chrome/browser/extensions/extension_browser_event_router.cc1
-rw-r--r--chrome/browser/extensions/extension_page_actions_module.cc1
-rw-r--r--chrome/browser/extensions/extension_tabs_module.cc1
-rw-r--r--chrome/browser/extensions/extensions_service.cc1
-rw-r--r--chrome/browser/gtk/back_forward_button_gtk.cc1
-rw-r--r--chrome/browser/gtk/bookmark_bar_gtk.cc1
-rw-r--r--chrome/browser/gtk/browser_window_gtk.cc1
-rw-r--r--chrome/browser/gtk/hung_renderer_dialog_gtk.cc1
-rw-r--r--chrome/browser/gtk/options/general_page_gtk.cc1
-rw-r--r--chrome/browser/sessions/session_service.cc1
-rw-r--r--chrome/browser/sessions/tab_restore_service.cc1
-rw-r--r--chrome/browser/tab_contents/interstitial_page.cc2
-rw-r--r--chrome/browser/tab_contents/navigation_controller.cc2
-rw-r--r--chrome/browser/views/bookmark_menu_button.cc1
-rw-r--r--chrome/browser/views/frame/browser_view.cc1
-rw-r--r--chrome/browser/views/frame/browser_view.h1
-rw-r--r--chrome/browser/views/frame/opaque_browser_frame_view.cc1
-rw-r--r--chrome/browser/views/options/advanced_contents_view.cc1
-rw-r--r--chrome/browser/views/options/general_page_view.cc1
52 files changed, 102 insertions, 51 deletions
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 68094ef..6110c99 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -11,6 +11,7 @@
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_init.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/browser_window.h"
#import "chrome/browser/cocoa/about_window_controller.h"
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index ce16482..6211734 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_model.h"
#include "chrome/test/testing_profile.h"
+#include "net/url_request/url_request_status.h"
#include "testing/gtest/include/gtest/gtest.h"
// The following environment is configured for these tests:
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index 3a58327..3dce551 100755
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -22,6 +22,7 @@
#include "chrome/browser/automation/url_request_mock_http_job.h"
#include "chrome/browser/automation/url_request_slow_download_job.h"
#include "chrome/browser/blocked_popup_container.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_window.h"
#include "chrome/browser/dom_operation_notification_details.h"
#include "chrome/browser/download/download_manager.h"
diff --git a/chrome/browser/automation/automation_provider_list.cc b/chrome/browser/automation/automation_provider_list.cc
index 9597e7a..b803be1 100644
--- a/chrome/browser/automation/automation_provider_list.cc
+++ b/chrome/browser/automation/automation_provider_list.cc
@@ -5,8 +5,10 @@
#include "chrome/browser/automation/automation_provider_list.h"
#include <algorithm>
+
#include "base/logging.h"
#include "chrome/browser/automation/automation_provider.h"
+#include "chrome/browser/browser_process.h"
AutomationProviderList* AutomationProviderList::instance_ = NULL;
diff --git a/chrome/browser/bookmarks/bookmark_context_menu.cc b/chrome/browser/bookmarks/bookmark_context_menu.cc
index f453df7..61c35ce 100644
--- a/chrome/browser/bookmarks/bookmark_context_menu.cc
+++ b/chrome/browser/bookmarks/bookmark_context_menu.cc
@@ -16,13 +16,13 @@
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/tab_contents/page_navigator.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
#include "grit/generated_resources.h"
// TODO(port): Port these files.
#if defined(OS_WIN)
-#include "chrome/browser/tab_contents/tab_contents.h"
#include "views/window/window.h"
#endif
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index b1007c0..38f5818 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -14,6 +14,7 @@
#include "chrome/app/chrome_dll_resource.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/browser_window.h"
#include "chrome/browser/character_encoding.h"
@@ -292,6 +293,18 @@ void Browser::CreateBrowserWindow() {
}
///////////////////////////////////////////////////////////////////////////////
+// Getters & Setters
+
+const std::vector<std::wstring>& Browser::user_data_dir_profiles() const {
+ return g_browser_process->user_data_dir_profiles();
+}
+
+void Browser::set_user_data_dir_profiles(
+ const std::vector<std::wstring>& profiles) {
+ g_browser_process->user_data_dir_profiles() = profiles;
+}
+
+///////////////////////////////////////////////////////////////////////////////
// Browser, Creation Helpers:
// static
@@ -2709,3 +2722,14 @@ void Browser::RegisterAppPrefs(const std::wstring& app_name) {
prefs->RegisterDictionaryPref(window_pref.c_str());
}
+
+///////////////////////////////////////////////////////////////////////////////
+// BrowserToolbarModel (private):
+
+NavigationController* Browser::BrowserToolbarModel::GetNavigationController() {
+ // This |current_tab| can be NULL during the initialization of the
+ // toolbar during window creation (i.e. before any tabs have been added
+ // to the window).
+ TabContents* current_tab = browser_->GetSelectedTabContents();
+ return current_tab ? &current_tab->controller() : NULL;
+}
diff --git a/chrome/browser/browser.h b/chrome/browser/browser.h
index 16af168f..67aa5425 100644
--- a/chrome/browser/browser.h
+++ b/chrome/browser/browser.h
@@ -5,25 +5,24 @@
#ifndef CHROME_BROWSER_BROWSER_H_
#define CHROME_BROWSER_BROWSER_H_
-#include "base/basictypes.h"
-
#include <set>
#include <vector>
+#include "base/basictypes.h"
#include "base/gfx/rect.h"
#include "base/scoped_ptr.h"
-#include "chrome/browser/browser_process.h"
+#include "base/task.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/extensions/extension_function_dispatcher.h"
#include "chrome/browser/sessions/session_id.h"
#include "chrome/browser/shell_dialogs.h"
-#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/tabs/tab_strip_model.h"
+#include "chrome/browser/tab_contents/page_navigator.h"
#include "chrome/browser/tab_contents/tab_contents_delegate.h"
#include "chrome/browser/toolbar_model.h"
#include "chrome/common/notification_registrar.h"
#include "chrome/common/pref_member.h"
-#include "third_party/skia/include/core/SkBitmap.h"
+#include "testing/gtest/include/gtest/gtest_prod.h"
class BrowserIdleTimer;
class BrowserWindow;
@@ -33,6 +32,7 @@ class GoButton;
class LocationBar;
class PrefService;
class Profile;
+class SkBitmap;
class StatusBubble;
class TabNavigation;
@@ -114,9 +114,8 @@ class Browser : public TabStripModelDelegate,
Type type() const { return type_; }
Profile* profile() const { return profile_; }
- const std::vector<std::wstring>& user_data_dir_profiles() const {
- return g_browser_process->user_data_dir_profiles();
- }
+ const std::vector<std::wstring>& user_data_dir_profiles() const;
+
#if defined(UNIT_TEST)
// Sets the BrowserWindow. This is intended for testing and generally not
// useful outside of testing. Use CreateBrowserWindow outside of testing, or
@@ -135,9 +134,7 @@ class Browser : public TabStripModelDelegate,
// Setters /////////////////////////////////////////////////////////////////
- void set_user_data_dir_profiles(const std::vector<std::wstring>& profiles) {
- g_browser_process->user_data_dir_profiles() = profiles;
- }
+ void set_user_data_dir_profiles(const std::vector<std::wstring>& profiles);
// Browser Creation Helpers /////////////////////////////////////////////////
@@ -685,13 +682,7 @@ class Browser : public TabStripModelDelegate,
virtual ~BrowserToolbarModel() { }
// ToolbarModel implementation.
- virtual NavigationController* GetNavigationController() {
- // This |current_tab| can be NULL during the initialization of the
- // toolbar during window creation (i.e. before any tabs have been added
- // to the window).
- TabContents* current_tab = browser_->GetSelectedTabContents();
- return current_tab ? &current_tab->controller() : NULL;
- }
+ virtual NavigationController* GetNavigationController();
private:
Browser* browser_;
diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc
index 9f03460..ee398bf 100644
--- a/chrome/browser/browser_main.cc
+++ b/chrome/browser/browser_main.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/plugin_service.h"
#include "chrome/browser/process_singleton.h"
#include "chrome/browser/profile_manager.h"
+#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "chrome/browser/shell_integration.h"
#include "chrome/browser/user_data_manager.h"
#include "chrome/common/chrome_constants.h"
diff --git a/chrome/browser/browser_window.h b/chrome/browser/browser_window.h
index 2b3ed63..f7999be 100644
--- a/chrome/browser/browser_window.h
+++ b/chrome/browser/browser_window.h
@@ -210,7 +210,11 @@ class BrowserWindow {
#if defined(OS_WIN)
class BookmarkBarView;
class LocationBarView;
-#endif
+
+namespace views {
+class View;
+}
+#endif // defined(OS_WIN)
// A BrowserWindow utility interface used for accessing elements of the browser
// UI used only by UI test automation.
diff --git a/chrome/browser/child_process_security_policy.h b/chrome/browser/child_process_security_policy.h
index 22db422..bc905bb 100644
--- a/chrome/browser/child_process_security_policy.h
+++ b/chrome/browser/child_process_security_policy.h
@@ -10,7 +10,6 @@
#include <set>
#include "base/basictypes.h"
-#include "base/file_path.h"
#include "base/lock.h"
#include "base/singleton.h"
#include "testing/gtest/include/gtest/gtest_prod.h"
diff --git a/chrome/browser/chrome_plugin_host.cc b/chrome/browser/chrome_plugin_host.cc
index 4c56297..196a24d 100644
--- a/chrome/browser/chrome_plugin_host.cc
+++ b/chrome/browser/chrome_plugin_host.cc
@@ -40,6 +40,7 @@
#include "net/base/base64.h"
#include "net/base/cookie_monster.h"
#include "net/base/io_buffer.h"
+#include "net/base/net_errors.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_error_job.h"
#include "third_party/skia/include/core/SkBitmap.h"
diff --git a/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm b/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
index c8dd3ec..3aa9906 100644
--- a/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
+++ b/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
@@ -6,6 +6,7 @@
#import "chrome/browser/cocoa/bookmark_menu_bridge.h"
#import "chrome/browser/cocoa/bookmark_menu_cocoa_controller.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "webkit/glue/window_open_disposition.h" // CURRENT_TAB
@implementation BookmarkMenuCocoaController
diff --git a/chrome/browser/cocoa/command_observer_bridge.mm b/chrome/browser/cocoa/command_observer_bridge.mm
index 47ea888..cc4fc22 100644
--- a/chrome/browser/cocoa/command_observer_bridge.mm
+++ b/chrome/browser/cocoa/command_observer_bridge.mm
@@ -4,6 +4,8 @@
#import "chrome/browser/cocoa/command_observer_bridge.h"
+#include "base/logging.h"
+
CommandObserverBridge::CommandObserverBridge(
id<CommandObserverProtocol> observer, CommandUpdater* commands)
: observer_(observer), commands_(commands) {
diff --git a/chrome/browser/cocoa/preferences_window_controller.mm b/chrome/browser/cocoa/preferences_window_controller.mm
index 5df094c..1763262 100644
--- a/chrome/browser/cocoa/preferences_window_controller.mm
+++ b/chrome/browser/cocoa/preferences_window_controller.mm
@@ -18,6 +18,7 @@
#include "chrome/browser/profile.h"
#include "chrome/browser/session_startup_pref.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/notification_details.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_type.h"
diff --git a/chrome/browser/command_updater.cc b/chrome/browser/command_updater.cc
index c63c6a0..efb0724 100644
--- a/chrome/browser/command_updater.cc
+++ b/chrome/browser/command_updater.cc
@@ -2,13 +2,22 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <algorithm>
-
#include "chrome/browser/command_updater.h"
+#include <algorithm>
+
#include "base/logging.h"
+#include "base/observer_list.h"
#include "base/stl_util-inl.h"
+class CommandUpdater::Command {
+ public:
+ bool enabled;
+ ObserverList<CommandObserver> observers;
+
+ Command() : enabled(true) {}
+};
+
CommandUpdater::CommandUpdater(CommandUpdaterDelegate* handler)
: delegate_(handler) {
}
diff --git a/chrome/browser/command_updater.h b/chrome/browser/command_updater.h
index f0303fc..3a6b7ca 100644
--- a/chrome/browser/command_updater.h
+++ b/chrome/browser/command_updater.h
@@ -5,11 +5,8 @@
#ifndef CHROME_BROWSER_COMMAND_UPDATER_H_
#define CHROME_BROWSER_COMMAND_UPDATER_H_
-#include <vector>
-
#include "base/basictypes.h"
#include "base/hash_tables.h"
-#include "base/observer_list.h"
////////////////////////////////////////////////////////////////////////////////
//
@@ -74,13 +71,7 @@ class CommandUpdater {
private:
// A piece of data about a command - whether or not it is enabled, and a list
// of objects that observe the enabled state of this command.
- class Command {
- public:
- bool enabled;
- ObserverList<CommandObserver> observers;
-
- Command() : enabled(true) {}
- };
+ class Command;
// Get a Command node for a given command ID, creating an entry if it doesn't
// exist if desired.
diff --git a/chrome/browser/debugger/debugger_host.h b/chrome/browser/debugger/debugger_host.h
index 72e7276..1adf56d 100644
--- a/chrome/browser/debugger/debugger_host.h
+++ b/chrome/browser/debugger/debugger_host.h
@@ -7,8 +7,10 @@
#ifndef CHROME_BROWSER_DEBUGGER_DEBUGGER_HOST_H_
#define CHROME_BROWSER_DEBUGGER_DEBUGGER_HOST_H_
+#include <string>
+
#include "base/basictypes.h"
-#include "base/thread.h"
+#include "base/ref_counted.h"
class ListValue;
diff --git a/chrome/browser/debugger/debugger_io.h b/chrome/browser/debugger/debugger_io.h
index eeefd45..296acaa 100644
--- a/chrome/browser/debugger/debugger_io.h
+++ b/chrome/browser/debugger/debugger_io.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H_
#include <string>
-#include <vector>
#include "base/basictypes.h"
#include "base/ref_counted.h"
diff --git a/chrome/browser/debugger/debugger_io_socket.cc b/chrome/browser/debugger/debugger_io_socket.cc
index 86e8be6..537907e 100644
--- a/chrome/browser/debugger/debugger_io_socket.cc
+++ b/chrome/browser/debugger/debugger_io_socket.cc
@@ -8,6 +8,7 @@
#include "base/thread.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/debugger/debugger_shell.h"
+#include "net/base/telnet_server.h"
#include "v8/include/v8.h"
////////////////////////////////////////////////
diff --git a/chrome/browser/debugger/debugger_io_socket.h b/chrome/browser/debugger/debugger_io_socket.h
index ea7c522..c78c861 100644
--- a/chrome/browser/debugger/debugger_io_socket.h
+++ b/chrome/browser/debugger/debugger_io_socket.h
@@ -6,7 +6,7 @@
#define CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_SOCKET_H__
#include "chrome/browser/debugger/debugger_io.h"
-#include "net/base/telnet_server.h"
+#include "net/base/listen_socket.h"
class DebuggerHost;
class MessageLoop;
@@ -16,8 +16,8 @@ class MessageLoop;
// result we wind up having helper methods that we call with InvokeLater into
// the IO thread.
-class DebuggerInputOutputSocket: public DebuggerInputOutput,
- public ListenSocket::ListenSocketDelegate {
+class DebuggerInputOutputSocket : public DebuggerInputOutput,
+ public ListenSocket::ListenSocketDelegate {
public:
DebuggerInputOutputSocket(int port);
virtual ~DebuggerInputOutputSocket();
diff --git a/chrome/browser/debugger/debugger_remote_service.h b/chrome/browser/debugger/debugger_remote_service.h
index 8498e454..b43ba48 100644
--- a/chrome/browser/debugger/debugger_remote_service.h
+++ b/chrome/browser/debugger/debugger_remote_service.h
@@ -11,7 +11,6 @@
#include <string>
#include "base/basictypes.h"
-#include "base/scoped_ptr.h"
#include "chrome/browser/debugger/devtools_remote.h"
class DevToolsProtocolHandler;
diff --git a/chrome/browser/debugger/debugger_wrapper.h b/chrome/browser/debugger/debugger_wrapper.h
index 59184df..943b816 100644
--- a/chrome/browser/debugger/debugger_wrapper.h
+++ b/chrome/browser/debugger/debugger_wrapper.h
@@ -22,7 +22,6 @@
#include "base/basictypes.h"
#include "base/ref_counted.h"
-#include "base/scoped_ptr.h"
class DebuggerHost;
class DevToolsProtocolHandler;
diff --git a/chrome/browser/debugger/devtools_client_host.h b/chrome/browser/debugger/devtools_client_host.h
index c6a50cb..71534fb 100644
--- a/chrome/browser/debugger/devtools_client_host.h
+++ b/chrome/browser/debugger/devtools_client_host.h
@@ -5,8 +5,6 @@
#ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
#define CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
-#include <string>
-
#include "base/basictypes.h"
namespace IPC {
diff --git a/chrome/browser/debugger/devtools_remote_listen_socket.h b/chrome/browser/debugger/devtools_remote_listen_socket.h
index 0f64eec..8c9db705 100644
--- a/chrome/browser/debugger/devtools_remote_listen_socket.h
+++ b/chrome/browser/debugger/devtools_remote_listen_socket.h
@@ -7,7 +7,6 @@
#include <string>
-#include "base/hash_tables.h"
#include "chrome/browser/debugger/devtools_remote_message.h"
#include "net/base/listen_socket.h"
diff --git a/chrome/browser/debugger/devtools_remote_message.h b/chrome/browser/debugger/devtools_remote_message.h
index ec75679..fa37caa 100644
--- a/chrome/browser/debugger/devtools_remote_message.h
+++ b/chrome/browser/debugger/devtools_remote_message.h
@@ -9,7 +9,6 @@
#include "base/basictypes.h"
#include "base/hash_tables.h"
-#include "base/logging.h"
// Contains DevTools protocol message header names
// and the Flags header bit field constants.
diff --git a/chrome/browser/debugger/devtools_sanity_unittest.cc b/chrome/browser/debugger/devtools_sanity_unittest.cc
index 71b4ab5..d52d9cd 100644
--- a/chrome/browser/debugger/devtools_sanity_unittest.cc
+++ b/chrome/browser/debugger/devtools_sanity_unittest.cc
@@ -4,6 +4,7 @@
#include "base/command_line.h"
#include "chrome/browser/browser.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/debugger/devtools_client_host.h"
#include "chrome/browser/debugger/devtools_manager.h"
#include "chrome/browser/debugger/devtools_window.h"
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc
index 5dfa557..99b0dcc 100644
--- a/chrome/browser/debugger/devtools_window.cc
+++ b/chrome/browser/debugger/devtools_window.cc
@@ -5,6 +5,7 @@
#include "app/l10n_util.h"
#include "base/command_line.h"
#include "chrome/browser/browser.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_window.h"
#include "chrome/browser/debugger/devtools_client_host.h"
#include "chrome/browser/debugger/devtools_manager.h"
diff --git a/chrome/browser/dom_ui/debugger_ui.cc b/chrome/browser/dom_ui/debugger_ui.cc
index 7467571..fd29146 100644
--- a/chrome/browser/dom_ui/debugger_ui.cc
+++ b/chrome/browser/dom_ui/debugger_ui.cc
@@ -7,7 +7,9 @@
#include "app/resource_bundle.h"
#include "base/command_line.h"
#include "base/file_util.h"
+#include "base/message_loop.h"
#include "base/string_util.h"
+#include "base/thread.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/debugger/debugger_shell.h"
diff --git a/chrome/browser/dom_ui/dom_ui.h b/chrome/browser/dom_ui/dom_ui.h
index fadff05..553ab28 100644
--- a/chrome/browser/dom_ui/dom_ui.h
+++ b/chrome/browser/dom_ui/dom_ui.h
@@ -12,7 +12,6 @@
#include "base/string16.h"
#include "base/task.h"
#include "chrome/common/page_transition_types.h"
-#include "webkit/glue/window_open_disposition.h"
class DictionaryValue;
class DOMMessageHandler;
diff --git a/chrome/browser/dom_ui/downloads_dom_handler.cc b/chrome/browser/dom_ui/downloads_dom_handler.cc
index 1f2c217..3a5388c 100644
--- a/chrome/browser/dom_ui/downloads_dom_handler.cc
+++ b/chrome/browser/dom_ui/downloads_dom_handler.cc
@@ -10,6 +10,7 @@
#include "base/string_piece.h"
#include "base/thread.h"
#include "base/time_format.h"
+#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/dom_ui/chrome_url_data_manager.h"
#include "chrome/browser/dom_ui/fileicon_source.h"
@@ -340,7 +341,7 @@ std::wstring DownloadsDOMHandler::GetProgressStatusText(
time_remaining = TimeFormat::TimeRemaining(remaining);
if (time_remaining.empty()) {
- return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS_TIME_UNKNOWN,
+ return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS_TIME_UNKNOWN,
speed_text, amount);
}
return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS, speed_text,
diff --git a/chrome/browser/dom_ui/downloads_dom_handler.h b/chrome/browser/dom_ui/downloads_dom_handler.h
index d8e6501..729960c 100644
--- a/chrome/browser/dom_ui/downloads_dom_handler.h
+++ b/chrome/browser/dom_ui/downloads_dom_handler.h
@@ -7,10 +7,12 @@
#include <vector>
-#include "base/values.h"
#include "chrome/browser/dom_ui/dom_ui.h"
#include "chrome/browser/download/download_manager.h"
+class DictionaryValue;
+class Value;
+
// The handler for Javascript messages related to the "downloads" view,
// also observes changes to the download manager.
class DownloadsDOMHandler : public DOMMessageHandler,
diff --git a/chrome/browser/dom_ui/html_dialog_ui.h b/chrome/browser/dom_ui/html_dialog_ui.h
index 29895d2..76240cd 100644
--- a/chrome/browser/dom_ui/html_dialog_ui.h
+++ b/chrome/browser/dom_ui/html_dialog_ui.h
@@ -5,11 +5,14 @@
#ifndef CHROME_BROWSER_DOM_UI_HTML_DIALOG_UI_H_
#define CHROME_BROWSER_DOM_UI_HTML_DIALOG_UI_H_
-#include "base/gfx/size.h"
#include "chrome/browser/dom_ui/dom_ui.h"
#include "chrome/common/property_bag.h"
#include "googleurl/src/gurl.h"
+namespace gfx {
+class Size;
+}
+
// Implement this class to receive notifications.
class HtmlDialogUIDelegate {
public:
diff --git a/chrome/browser/encoding_menu_controller.cc b/chrome/browser/encoding_menu_controller.cc
index ca8c964..042ff9a 100644
--- a/chrome/browser/encoding_menu_controller.cc
+++ b/chrome/browser/encoding_menu_controller.cc
@@ -6,7 +6,7 @@
#include "app/l10n_util.h"
#include "chrome/app/chrome_dll_resource.h"
-#include "chrome/browser/browser.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/character_encoding.h"
#include "chrome/browser/profile.h"
#include "chrome/common/pref_names.h"
diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc
index e0848c2..ad69ba5 100644
--- a/chrome/browser/extensions/extension_browser_event_router.cc
+++ b/chrome/browser/extensions/extension_browser_event_router.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/extensions/extension_message_service.h"
#include "chrome/browser/extensions/extension_tabs_module_constants.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/notification_service.h"
diff --git a/chrome/browser/extensions/extension_page_actions_module.cc b/chrome/browser/extensions/extension_page_actions_module.cc
index ab943e0..5b128ea 100644
--- a/chrome/browser/extensions/extension_page_actions_module.cc
+++ b/chrome/browser/extensions/extension_page_actions_module.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/extension_tabs_module.h"
#include "chrome/browser/extensions/extensions_service.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_error_utils.h"
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 761e874..2eb2432 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/profile.h"
#include "chrome/browser/renderer_host/render_view_host_delegate.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/window_sizer.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_error_utils.h"
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index 4cad6eb..aae153b 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -11,6 +11,7 @@
#include "base/gfx/png_encoder.h"
#include "base/scoped_handle.h"
#include "base/scoped_temp_dir.h"
+#include "base/stl_util-inl.h"
#include "base/string_util.h"
#include "base/third_party/nss/blapi.h"
#include "base/third_party/nss/sha256.h"
diff --git a/chrome/browser/gtk/back_forward_button_gtk.cc b/chrome/browser/gtk/back_forward_button_gtk.cc
index ae46c4d..c74ac22 100644
--- a/chrome/browser/gtk/back_forward_button_gtk.cc
+++ b/chrome/browser/gtk/back_forward_button_gtk.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/gtk/back_forward_menu_model_gtk.h"
#include "chrome/browser/gtk/menu_gtk.h"
#include "grit/generated_resources.h"
+#include "grit/theme_resources.h"
// The time in milliseconds between when the user clicks and the menu appears.
static const int kMenuTimerDelay = 500;
diff --git a/chrome/browser/gtk/bookmark_bar_gtk.cc b/chrome/browser/gtk/bookmark_bar_gtk.cc
index 181e4a2..33279bd 100644
--- a/chrome/browser/gtk/bookmark_bar_gtk.cc
+++ b/chrome/browser/gtk/bookmark_bar_gtk.cc
@@ -24,6 +24,7 @@
#include "chrome/browser/gtk/tabs/tab_strip_gtk.h"
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/profile.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/gtk_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc
index d62c7a1..d3107f1 100644
--- a/chrome/browser/gtk/browser_window_gtk.cc
+++ b/chrome/browser/gtk/browser_window_gtk.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/download/download_item_model.h"
#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/gtk/about_chrome_dialog.h"
diff --git a/chrome/browser/gtk/hung_renderer_dialog_gtk.cc b/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
index 02a7c8b..54b0f3a 100644
--- a/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
+++ b/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
@@ -11,6 +11,7 @@
#include "base/gfx/gtk_util.h"
#include "base/process_util.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/gtk_util.h"
#include "chrome/common/logging_chrome.h"
#include "chrome/common/result_codes.h"
diff --git a/chrome/browser/gtk/options/general_page_gtk.cc b/chrome/browser/gtk/options/general_page_gtk.cc
index a9ebcd7..21a8549 100644
--- a/chrome/browser/gtk/options/general_page_gtk.cc
+++ b/chrome/browser/gtk/options/general_page_gtk.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/session_startup_pref.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/gtk_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
diff --git a/chrome/browser/sessions/session_service.cc b/chrome/browser/sessions/session_service.cc
index 786e56c..33a5e6f 100644
--- a/chrome/browser/sessions/session_service.cc
+++ b/chrome/browser/sessions/session_service.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/sessions/session_types.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/notification_details.h"
#include "chrome/common/notification_service.h"
diff --git a/chrome/browser/sessions/tab_restore_service.cc b/chrome/browser/sessions/tab_restore_service.cc
index d857de9..2915deb 100644
--- a/chrome/browser/sessions/tab_restore_service.cc
+++ b/chrome/browser/sessions/tab_restore_service.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/sessions/session_command.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
using base::Time;
diff --git a/chrome/browser/tab_contents/interstitial_page.cc b/chrome/browser/tab_contents/interstitial_page.cc
index 15959be..efbc033 100644
--- a/chrome/browser/tab_contents/interstitial_page.cc
+++ b/chrome/browser/tab_contents/interstitial_page.cc
@@ -7,8 +7,8 @@
#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "base/thread.h"
-#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/dom_operation_notification_details.h"
#include "chrome/browser/renderer_host/render_widget_host_view.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
diff --git a/chrome/browser/tab_contents/navigation_controller.cc b/chrome/browser/tab_contents/navigation_controller.cc
index e33898d..eb6441a 100644
--- a/chrome/browser/tab_contents/navigation_controller.cc
+++ b/chrome/browser/tab_contents/navigation_controller.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/tab_contents/navigation_entry.h"
#include "chrome/browser/tab_contents/repost_form_warning.h"
#include "chrome/browser/tab_contents/site_instance.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/navigation_types.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/pref_names.h"
@@ -30,7 +31,6 @@
#if defined(OS_WIN)
#include "chrome/browser/tab_contents/repost_form_warning.h"
-#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/tab_contents/tab_contents_delegate.h"
#endif
diff --git a/chrome/browser/views/bookmark_menu_button.cc b/chrome/browser/views/bookmark_menu_button.cc
index b06e0df..2b299cb 100644
--- a/chrome/browser/views/bookmark_menu_button.cc
+++ b/chrome/browser/views/bookmark_menu_button.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/profile.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/view_ids.h"
#include "grit/theme_resources.h"
#include "views/widget/widget.h"
diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc
index db7a04f..2c2d7a6 100644
--- a/chrome/browser/views/frame/browser_view.cc
+++ b/chrome/browser/views/frame/browser_view.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/extensions/extension_shelf.h"
#include "chrome/browser/find_bar.h"
diff --git a/chrome/browser/views/frame/browser_view.h b/chrome/browser/views/frame/browser_view.h
index b6d8dcc..eb1c3dc8 100644
--- a/chrome/browser/views/frame/browser_view.h
+++ b/chrome/browser/views/frame/browser_view.h
@@ -8,6 +8,7 @@
#include <set>
#include "base/gfx/native_widget_types.h"
+#include "base/timer.h"
#include "build/build_config.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_window.h"
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.cc b/chrome/browser/views/frame/opaque_browser_frame_view.cc
index 5d73082..bcfe6c0 100644
--- a/chrome/browser/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/views/frame/opaque_browser_frame_view.cc
@@ -11,6 +11,7 @@
#include "app/resource_bundle.h"
#include "app/theme_provider.h"
#include "chrome/browser/browser_theme_provider.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/views/frame/browser_frame.h"
#include "chrome/browser/views/frame/browser_view.h"
#include "chrome/browser/views/tabs/tab_strip.h"
diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc
index 880d51f..e94c040 100644
--- a/chrome/browser/views/options/advanced_contents_view.cc
+++ b/chrome/browser/views/options/advanced_contents_view.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/gears_integration.h"
#include "chrome/browser/metrics/metrics_service.h"
#include "chrome/browser/net/dns_global.h"
+#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/browser/shell_dialogs.h"
#include "chrome/browser/views/options/cookies_view.h"
diff --git a/chrome/browser/views/options/general_page_view.cc b/chrome/browser/views/options/general_page_view.cc
index a248f27..5d08722 100644
--- a/chrome/browser/views/options/general_page_view.cc
+++ b/chrome/browser/views/options/general_page_view.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_model.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/views/keyword_editor_view.h"
#include "chrome/browser/views/options/options_group_view.h"
#include "chrome/browser/dom_ui/new_tab_ui.h"