summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorshess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-12 20:24:26 +0000
committershess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-12 20:24:26 +0000
commit863594cdefe1b4380db0e43bf3ccd77136eaf2c8 (patch)
treec0f10a19c1b233c76b73e2d372ccb1af327a5711 /chrome/browser
parent72c47e6882d9e9b509eef006037a3d382a7440bd (diff)
downloadchromium_src-863594cdefe1b4380db0e43bf3ccd77136eaf2c8.zip
chromium_src-863594cdefe1b4380db0e43bf3ccd77136eaf2c8.tar.gz
chromium_src-863594cdefe1b4380db0e43bf3ccd77136eaf2c8.tar.bz2
Revert "[Mac] Add breakpad info for crashes in the target/action dispatcher."
Breaks the Release compile somehow. Sigh. TBR=michaeln,mmoss Review URL: http://codereview.chromium.org/266053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28734 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/chrome_application_mac.mm47
1 files changed, 0 insertions, 47 deletions
diff --git a/chrome/browser/chrome_application_mac.mm b/chrome/browser/chrome_application_mac.mm
index 2457dc2..a81326f 100644
--- a/chrome/browser/chrome_application_mac.mm
+++ b/chrome/browser/chrome_application_mac.mm
@@ -4,30 +4,6 @@
#import "chrome/browser/chrome_application_mac.h"
-#import "base/scoped_nsobject.h"
-#import "chrome/app/breakpad_mac.h"
-
-namespace {
-
-// Helper to make it easy to get crash keys right.
-// TODO(shess): Find a better home for this. app/breakpad_mac.h
-// doesn't work.
-class ScopedCrashKey {
- public:
- ScopedCrashKey(NSString* key, NSString* value)
- : crash_key_([key retain]) {
- SetCrashKeyValue(crash_key_.get(), value);
- }
- ~ScopedCrashKey() {
- ClearCrashKeyValue(crash_key_.get());
- }
-
- private:
- scoped_nsobject<NSString> crash_key_;
-};
-
-} // namespace
-
@implementation CrApplication
// -terminate: is the entry point for orderly "quit" operations in Cocoa.
@@ -104,29 +80,6 @@ class ScopedCrashKey {
}
}
- // When a Cocoa control is wired to a freed object, we get crashers
- // in the call to |super| with no useful information in the
- // backtrace. Attempt to add some useful information.
- static const NSString* kActionKey = @"sendaction";
-
- // If the action is something generic like -commandDispatch:, then
- // the tag is essential.
- NSInteger tag = 0;
- if ([sender isKindOfClass:[NSControl class]]) {
- tag = [sender tag];
- if (tag == 0 || tag == -1) {
- tag = [sender selectedTag];
- }
- } else if ([sender isKindOfClass:[NSMenuItem class]]) {
- tag = [sender tag];
- }
-
- NSString* actionString = NSStringFromSelector(anAction);
- NSString* value =
- [NSString stringWithFormat:@"%@ tag %d sending %@ to %p",
- [sender className], tag, actionString, aTarget];
-
- ScopedCrashKey key(kActionKey, value);
return [super sendAction:anAction to:aTarget from:sender];
}