diff options
| author | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-22 00:12:15 +0000 |
|---|---|---|
| committer | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-22 00:12:15 +0000 |
| commit | 124825ede0f1ff53db9ca2255142c4fcec1ad5ca (patch) | |
| tree | a6182880b9caba34bf738bee043c109ba16838a7 /chrome/browser | |
| parent | 478ff2ed6a244658c0a30d6cbfff1a9046b9ba9d (diff) | |
| download | chromium_src-124825ede0f1ff53db9ca2255142c4fcec1ad5ca.zip chromium_src-124825ede0f1ff53db9ca2255142c4fcec1ad5ca.tar.gz chromium_src-124825ede0f1ff53db9ca2255142c4fcec1ad5ca.tar.bz2 | |
Provide an override for Webview drop effect.
Used for gears file drag & drop in chrome, provide a setter api to override
the default webview drop effect. If gears overrides the drop_effect, then
either a "copy" or "none" cursor is shown to the user. Otherwise, the drop
effect shown is the default for the webview (controlled by WebKit).
Also remove a TODO: during drag and drop, remember the drop accept state of
the webview (in drag enter, drag over). Use that to prevent drops on webviews
that can't accept the drop data.
BUG=7995
Original patch from Noel Gordon via
http://codereview.chromium.org/67297
Review URL: http://codereview.chromium.org/88073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14162 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/tab_contents/web_drop_target.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/browser/tab_contents/web_drop_target.cc b/chrome/browser/tab_contents/web_drop_target.cc index eb740ee..f934f62 100644 --- a/chrome/browser/tab_contents/web_drop_target.cc +++ b/chrome/browser/tab_contents/web_drop_target.cc @@ -136,12 +136,6 @@ DWORD WebDropTarget::OnDragOver(IDataObject* data_object, gfx::Point(client_pt.x, client_pt.y), gfx::Point(cursor_position.x, cursor_position.y)); - // Again we don't wait on the renderer to respond, but this can lead to - // a race condition. If the renderer does not want the drop data, then - // we won't know until the response from the renderer arrives. So if a - // drop happens before the response arrives, we drop on a renderer that - // doesn't want the data. TODO(noel): fix this. - if (!is_drop_target_) return DROPEFFECT_NONE; |