diff options
author | huanr@chromium.org <huanr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-31 04:16:44 +0000 |
---|---|---|
committer | huanr@chromium.org <huanr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-31 04:16:44 +0000 |
commit | 49a14a8af7d0186c0c6de56271dffdf54643b5fd (patch) | |
tree | 55403096e800c9c8685d800f313d5710afe02dc6 /chrome/browser | |
parent | 80f8dafc252632661d8c26835f0d92b387390532 (diff) | |
download | chromium_src-49a14a8af7d0186c0c6de56271dffdf54643b5fd.zip chromium_src-49a14a8af7d0186c0c6de56271dffdf54643b5fd.tar.gz chromium_src-49a14a8af7d0186c0c6de56271dffdf54643b5fd.tar.bz2 |
Mechanic change based on comment from previous code review.
Rename RunCommand to RunCommandAsync and RunCommandSync to
RunCommand.
Review URL: http://codereview.chromium.org/57039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r-- | chrome/browser/automation/automation_provider.cc | 11 | ||||
-rw-r--r-- | chrome/browser/download/save_page_uitest.cc | 4 | ||||
-rw-r--r-- | chrome/browser/views/find_bar_win_uitest.cc | 2 |
3 files changed, 8 insertions, 9 deletions
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc index 954db43..b3699b8 100644 --- a/chrome/browser/automation/automation_provider.cc +++ b/chrome/browser/automation/automation_provider.cc @@ -471,8 +471,8 @@ class ExecuteBrowserCommandObserver : public NotificationObserver { const NotificationSource& source, const NotificationDetails& details) { if (type == notification_type_) { - AutomationMsg_WindowExecuteCommandSync::WriteReplyParams(reply_message_, - true); + AutomationMsg_WindowExecuteCommand::WriteReplyParams(reply_message_, + true); automation_->Send(reply_message_); delete this; } else { @@ -837,9 +837,9 @@ void AutomationProvider::OnMessageReceived(const IPC::Message& message) { #if defined(OS_WIN) IPC_MESSAGE_HANDLER(AutomationMsg_WindowHWND, GetWindowHWND) #endif // defined(OS_WIN) - IPC_MESSAGE_HANDLER(AutomationMsg_WindowExecuteCommand, + IPC_MESSAGE_HANDLER(AutomationMsg_WindowExecuteCommandAsync, ExecuteBrowserCommand) - IPC_MESSAGE_HANDLER_DELAY_REPLY(AutomationMsg_WindowExecuteCommandSync, + IPC_MESSAGE_HANDLER_DELAY_REPLY(AutomationMsg_WindowExecuteCommand, ExecuteBrowserCommandWithNotification) IPC_MESSAGE_HANDLER(AutomationMsg_WindowViewBounds, WindowGetViewBounds) @@ -1335,8 +1335,7 @@ void AutomationProvider::ExecuteBrowserCommandWithNotification( return; } } - AutomationMsg_WindowExecuteCommandSync::WriteReplyParams(reply_message, - false); + AutomationMsg_WindowExecuteCommand::WriteReplyParams(reply_message, false); Send(reply_message); } diff --git a/chrome/browser/download/save_page_uitest.cc b/chrome/browser/download/save_page_uitest.cc index 6531267..78e3759 100644 --- a/chrome/browser/download/save_page_uitest.cc +++ b/chrome/browser/download/save_page_uitest.cc @@ -135,7 +135,7 @@ TEST_F(SavePageTest, FilenameFromPageTitle) { scoped_ptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); automation()->SavePackageShouldPromptUser(false); - EXPECT_TRUE(browser->RunCommand(IDC_SAVE_PAGE)); + EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE)); EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get())); automation()->SavePackageShouldPromptUser(true); @@ -158,7 +158,7 @@ TEST_F(SavePageTest, CleanFilenameFromPageTitle) { scoped_ptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); automation()->SavePackageShouldPromptUser(false); - EXPECT_TRUE(browser->RunCommand(IDC_SAVE_PAGE)); + EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE)); EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get())); automation()->SavePackageShouldPromptUser(true); diff --git a/chrome/browser/views/find_bar_win_uitest.cc b/chrome/browser/views/find_bar_win_uitest.cc index 88dc0ed..e646fde 100644 --- a/chrome/browser/views/find_bar_win_uitest.cc +++ b/chrome/browser/views/find_bar_win_uitest.cc @@ -315,7 +315,7 @@ TEST_F(FindInPageControllerTest, FindDisappearOnNewTabAndHistory) { EXPECT_TRUE(WaitForFindWindowVisibilityChange(browser.get(), true)); // Open History page. - EXPECT_TRUE(browser->RunCommand(IDC_SHOW_HISTORY)); + EXPECT_TRUE(browser->RunCommandAsync(IDC_SHOW_HISTORY)); // Wait for the Find box to disappear. EXPECT_TRUE(WaitForFindWindowVisibilityChange(browser.get(), false)); |