summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-08 09:26:20 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-08 09:26:20 +0000
commit8cb024834fbdf3fed7736d3cb8abb83c3eb3fcaf (patch)
tree15c9656a9c6f8fb8804f7f9634c8e87b21d6e846 /chrome/browser
parent90142dde1d915b76b56c83ca87c7c26090503477 (diff)
downloadchromium_src-8cb024834fbdf3fed7736d3cb8abb83c3eb3fcaf.zip
chromium_src-8cb024834fbdf3fed7736d3cb8abb83c3eb3fcaf.tar.gz
chromium_src-8cb024834fbdf3fed7736d3cb8abb83c3eb3fcaf.tar.bz2
Add some more debugging info to the --diagnostics for when checking filepath.
BUG=None TEST=None Review URL: http://codereview.chromium.org/6413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74104 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/diagnostics/recon_diagnostics.cc14
1 files changed, 10 insertions, 4 deletions
diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc
index d8f9526..218e85f 100644
--- a/chrome/browser/diagnostics/recon_diagnostics.cc
+++ b/chrome/browser/diagnostics/recon_diagnostics.cc
@@ -240,7 +240,8 @@ class PathTest : public DiagnosticTest {
return false;
}
if (!file_util::PathExists(dir_or_file)) {
- RecordFailure(ASCIIToUTF16("Path not found"));
+ RecordFailure(ASCIIToUTF16("Path not found: ") +
+ dir_or_file.LossyDisplayName());
return true;
}
@@ -251,7 +252,8 @@ class PathTest : public DiagnosticTest {
file_util::GetFileSize(dir_or_file, &dir_or_file_size);
}
if (!dir_or_file_size && !path_info_.is_optional) {
- RecordFailure(ASCIIToUTF16("Cannot obtain size"));
+ RecordFailure(ASCIIToUTF16("Cannot obtain size for: ") +
+ dir_or_file.LossyDisplayName());
return true;
}
DataUnits units = GetByteDisplayUnits(dir_or_file_size);
@@ -259,7 +261,10 @@ class PathTest : public DiagnosticTest {
if (path_info_.max_size > 0) {
if (dir_or_file_size > path_info_.max_size) {
- RecordFailure(ASCIIToUTF16("Path is too big: ") + printable_size);
+ RecordFailure(ASCIIToUTF16("Path contents too large (") +
+ printable_size +
+ ASCIIToUTF16(") for: ") +
+ dir_or_file.LossyDisplayName());
return true;
}
}
@@ -268,7 +273,8 @@ class PathTest : public DiagnosticTest {
return true;
}
if (!file_util::PathIsWritable(dir_or_file)) {
- RecordFailure(ASCIIToUTF16("Path is not writable"));
+ RecordFailure(ASCIIToUTF16("Path is not writable: ") +
+ dir_or_file.LossyDisplayName());
return true;
}
RecordSuccess(ASCIIToUTF16("Path exists and is writable: ")