diff options
author | saintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-20 21:20:33 +0000 |
---|---|---|
committer | saintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-20 21:20:33 +0000 |
commit | 9edeb71c75df9eed63d4e27e90c2ddfc287049b8 (patch) | |
tree | 219f94803f3193301e3d606693bb7d1a74ab2264 /chrome/browser | |
parent | 20960e074cf789825155f771e1c035df41cd0e75 (diff) | |
download | chromium_src-9edeb71c75df9eed63d4e27e90c2ddfc287049b8.zip chromium_src-9edeb71c75df9eed63d4e27e90c2ddfc287049b8.tar.gz chromium_src-9edeb71c75df9eed63d4e27e90c2ddfc287049b8.tar.bz2 |
Making TOOLKIT_USES_GTK orthogonal to USE_AURA.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102019 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r-- | chrome/browser/chrome_browser_main_posix.cc | 4 | ||||
-rw-r--r-- | chrome/browser/profiles/profile.cc | 4 | ||||
-rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_views.cc | 4 | ||||
-rw-r--r-- | chrome/browser/renderer_preferences_util.cc | 10 | ||||
-rw-r--r-- | chrome/browser/themes/theme_service.h | 2 | ||||
-rw-r--r-- | chrome/browser/themes/theme_service_factory.cc | 4 | ||||
-rw-r--r-- | chrome/browser/ui/views/frame/browser_view.cc | 4 |
7 files changed, 16 insertions, 16 deletions
diff --git a/chrome/browser/chrome_browser_main_posix.cc b/chrome/browser/chrome_browser_main_posix.cc index 518d8ecf..aa54aec 100644 --- a/chrome/browser/chrome_browser_main_posix.cc +++ b/chrome/browser/chrome_browser_main_posix.cc @@ -20,7 +20,7 @@ #include "chrome/common/chrome_switches.h" #include "content/browser/browser_thread.h" -#if defined(TOOLKIT_USES_GTK) && !defined(OS_CHROMEOS) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) && !defined(OS_CHROMEOS) #include "chrome/browser/printing/print_dialog_gtk.h" #endif @@ -255,7 +255,7 @@ void ChromeBrowserMainPartsPosix::PostMainMessageLoopStart() { action.sa_handler = SIGHUPHandler; CHECK(sigaction(SIGHUP, &action, NULL) == 0); -#if defined(TOOLKIT_USES_GTK) && !defined(OS_CHROMEOS) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) && !defined(OS_CHROMEOS) printing::PrintingContextCairo::SetCreatePrintDialogFunction( &PrintDialogGtk::CreatePrintDialog); #endif diff --git a/chrome/browser/profiles/profile.cc b/chrome/browser/profiles/profile.cc index b59fe42..13fb35f 100644 --- a/chrome/browser/profiles/profile.cc +++ b/chrome/browser/profiles/profile.cc @@ -62,7 +62,7 @@ #include "webkit/database/database_tracker.h" #include "webkit/quota/quota_manager.h" -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) #include "chrome/browser/ui/gtk/gtk_theme_service.h" #endif @@ -140,7 +140,7 @@ void Profile::RegisterUserPrefs(PrefService* prefs) { prefs->RegisterBooleanPref(prefs::kSpeechInputCensorResults, true, PrefService::UNSYNCABLE_PREF); -#if defined(TOOLKIT_USES_GTK) & !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) prefs->RegisterBooleanPref(prefs::kUsesSystemTheme, GtkThemeService::DefaultUsesSystemTheme(), PrefService::UNSYNCABLE_PREF); diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc index 7b35392..8808c4a 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_views.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc @@ -777,7 +777,7 @@ void RenderWidgetHostViewViews::OnPaint(gfx::Canvas* canvas) { paint_rect = paint_rect.Intersect(invalid_rect_); if (backing_store) { -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) // Only render the widget if it is attached to a window; there's a short // period where this object isn't attached to a window but hasn't been // Destroy()ed yet and it receives paint messages... @@ -797,7 +797,7 @@ void RenderWidgetHostViewViews::OnPaint(gfx::Canvas* canvas) { // TODO(sad) NOTIMPLEMENTED(); } -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) } #endif if (!whiteout_start_time_.is_null()) { diff --git a/chrome/browser/renderer_preferences_util.cc b/chrome/browser/renderer_preferences_util.cc index c37ea5d..a585d43 100644 --- a/chrome/browser/renderer_preferences_util.cc +++ b/chrome/browser/renderer_preferences_util.cc @@ -8,7 +8,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/common/pref_names.h" -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) #include "chrome/browser/ui/gtk/gtk_theme_service.h" #include "chrome/browser/ui/gtk/gtk_util.h" #endif @@ -16,10 +16,10 @@ namespace renderer_preferences_util { void UpdateFromSystemSettings(RendererPreferences* prefs, Profile* profile) { -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) gtk_util::UpdateGtkFontSettings(prefs); -#if !defined(OS_CHROMEOS) && !defined(USE_AURA) +#if !defined(OS_CHROMEOS) GtkThemeService* theme_service = GtkThemeService::GetFrom(profile); prefs->focus_ring_color = theme_service->get_focus_ring_color(); @@ -40,9 +40,9 @@ void UpdateFromSystemSettings(RendererPreferences* prefs, Profile* profile) { prefs->active_selection_fg_color = SK_ColorBLACK; prefs->inactive_selection_bg_color = SkColorSetRGB(0xEA, 0xEA, 0xEA); prefs->inactive_selection_fg_color = SK_ColorBLACK; -#endif // defined(OS_CHROMEOS) && defined(USE_AURA) +#endif // defined(OS_CHROMEOS) -#endif // defined(TOOLKIT_USES_GTK) && defined(USE_AURA) +#endif // defined(TOOLKIT_USES_GTK) prefs->enable_referrers = profile->GetPrefs()->GetBoolean(prefs::kEnableReferrers); diff --git a/chrome/browser/themes/theme_service.h b/chrome/browser/themes/theme_service.h index 861164c..4b8a3ca 100644 --- a/chrome/browser/themes/theme_service.h +++ b/chrome/browser/themes/theme_service.h @@ -147,7 +147,7 @@ class ThemeService : public base::NonThreadSafe, virtual bool ShouldUseNativeFrame() const; virtual bool HasCustomImage(int id) const; virtual RefCountedMemory* GetRawData(int id) const; -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) // GdkPixbufs returned by GetPixbufNamed and GetRTLEnabledPixbufNamed are // shared instances owned by the theme provider and should not be freed. virtual GdkPixbuf* GetPixbufNamed(int id) const; diff --git a/chrome/browser/themes/theme_service_factory.cc b/chrome/browser/themes/theme_service_factory.cc index 21fa817..861614d 100644 --- a/chrome/browser/themes/theme_service_factory.cc +++ b/chrome/browser/themes/theme_service_factory.cc @@ -11,7 +11,7 @@ #include "chrome/browser/themes/theme_service.h" #include "content/common/notification_service.h" -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) #include "chrome/browser/ui/gtk/gtk_theme_service.h" #endif @@ -45,7 +45,7 @@ ThemeServiceFactory::~ThemeServiceFactory() {} ProfileKeyedService* ThemeServiceFactory::BuildServiceInstanceFor( Profile* profile) const { ThemeService* provider = NULL; -#if defined(TOOLKIT_USES_GTK) && !defined(USE_AURA) +#if defined(TOOLKIT_USES_GTK) provider = new GtkThemeService; #else provider = new ThemeService; diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index a0580b3..8bdf6ad 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -1246,7 +1246,7 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, views::FocusManager* focus_manager = GetFocusManager(); DCHECK(focus_manager); -#if defined(TOOLKIT_USES_GTK) && !(defined(TOUCH_UI) || defined(USE_AURA)) +#if defined(TOOLKIT_USES_GTK) && !defined(TOUCH_UI) // Views and WebKit use different tables for GdkEventKey -> views::KeyEvent // conversion. We need to use View's conversion table here to keep consistent // behavior with views::FocusManager::OnKeyEvent() method. @@ -1311,7 +1311,7 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, void BrowserView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) { // TODO(ben): figure out why are these two code paths so different -#if defined(TOOLKIT_USES_GTK) && !(defined(TOUCH_UI) || defined(USE_AURA)) +#if defined(TOOLKIT_USES_GTK) && !defined(TOUCH_UI) HandleWebKeyboardEvent(GetWidget(), event); #else unhandled_keyboard_event_handler_.HandleKeyboardEvent(event, |