diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 19:43:35 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 19:43:35 +0000 |
| commit | b1b6dec7089162e3629eb1174c9af4e263fc694d (patch) | |
| tree | e990331f405c5e50d0c7f849bd2142cf6623fc96 /chrome/browser | |
| parent | 8ae5bd6173ce7fb06e0952f00779ee78f4e6fd00 (diff) | |
| download | chromium_src-b1b6dec7089162e3629eb1174c9af4e263fc694d.zip chromium_src-b1b6dec7089162e3629eb1174c9af4e263fc694d.tar.gz chromium_src-b1b6dec7089162e3629eb1174c9af4e263fc694d.tar.bz2 | |
Fix another regression. Coordinate calculation in the OpaqueBrowserFrameView::HitTest method was wrong.
http://crbug.com/8365
Review URL: http://codereview.chromium.org/37008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10907 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/views/frame/opaque_browser_frame_view.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.cc b/chrome/browser/views/frame/opaque_browser_frame_view.cc index 03d755b..39ba2d0 100644 --- a/chrome/browser/views/frame/opaque_browser_frame_view.cc +++ b/chrome/browser/views/frame/opaque_browser_frame_view.cc @@ -575,8 +575,12 @@ bool OpaqueBrowserFrameView::HitTest(const gfx::Point& l) const { if (l.y() > browser_view_->tabstrip()->bounds().bottom()) return false; + // We convert from our parent's coordinates since we assume we fill its bounds + // completely. We need to do this since we're not a parent of the tabstrip, + // meaning ConvertPointToView would otherwise return something bogus. gfx::Point tabstrip_point(l); - View::ConvertPointToView(this, browser_view_->tabstrip(), &tabstrip_point); + View::ConvertPointToView(GetParent(), browser_view_->tabstrip(), + &tabstrip_point); return browser_view_->tabstrip()->PointIsWithinWindowCaption(tabstrip_point); } |