diff options
| author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-19 03:33:31 +0000 |
|---|---|---|
| committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-19 03:33:31 +0000 |
| commit | 6a6d5a990392ef64501de6d8663a52954b871e18 (patch) | |
| tree | bc9c53dc89b977529dfaa5a49e4f0a17cf63032f /chrome/browser | |
| parent | e5f89f3a1db6ac9af7904a10387a7f69aa7785d7 (diff) | |
| download | chromium_src-6a6d5a990392ef64501de6d8663a52954b871e18.zip chromium_src-6a6d5a990392ef64501de6d8663a52954b871e18.tar.gz chromium_src-6a6d5a990392ef64501de6d8663a52954b871e18.tar.bz2 | |
BookmarkManagerTest now passes without this hack.
I don't know exactly what's been changed thoguh.
We're going to enable this in build/try bots soon so we can tell when this comes back.
BUG=28046
TEST=browser_tests --gtest_filter=BookmarkManagerTest* should pass.
Review URL: http://codereview.chromium.org/399104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32484 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/gtk/bookmark_manager_browsertest.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/chrome/browser/gtk/bookmark_manager_browsertest.cc b/chrome/browser/gtk/bookmark_manager_browsertest.cc index 1d8b8b0..6cb3289 100644 --- a/chrome/browser/gtk/bookmark_manager_browsertest.cc +++ b/chrome/browser/gtk/bookmark_manager_browsertest.cc @@ -81,13 +81,4 @@ IN_PROC_BROWSER_TEST_F(BookmarkManagerTest, Crash) { manager_->SelectInTree(model_->GetBookmarkBarNode(), true); CleanUp(); -#if defined(TOOLKIT_VIEWS) - // The test fails on toolkit_views build without the following - // cleanup code. This is because the bookmark bar view refuses to - // be destroyed by a bookmark model when the BrowserProcessImpl - // destroys the bookmark bar model. - // TODO(oshima): http://crbug/28046. - browser()->window()->Close(); - MessageLoopForUI::current()->RunAllPending(); -#endif } |