diff options
| author | mirandac@google.com <mirandac@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-23 16:12:06 +0000 |
|---|---|---|
| committer | mirandac@google.com <mirandac@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-23 16:12:06 +0000 |
| commit | 074e4f42816dd34c87583edfe31c3d1794dd4584 (patch) | |
| tree | 380a4d615383894cd35fc22e4504d639b04a43e3 /chrome/browser | |
| parent | a0584b22312364d59e214d42941fc1c6076806d1 (diff) | |
| download | chromium_src-074e4f42816dd34c87583edfe31c3d1794dd4584.zip chromium_src-074e4f42816dd34c87583edfe31c3d1794dd4584.tar.gz chromium_src-074e4f42816dd34c87583edfe31c3d1794dd4584.tar.bz2 | |
Fix theme loading bubble which was overstaying its welcome.
Fixes problem introduced in http://codereview.chromium.org/2659004/show.
BUG=46710
TEST=Bring up a regular window, and an incognito window. Install theme from incognito window. Note that loading bubble disappears at the proper time.
Review URL: http://codereview.chromium.org/2823025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50602 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/browser.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/download/download_manager.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/extensions/extension_install_ui.cc | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc index 0935c25..c9802bd 100644 --- a/chrome/browser/browser.cc +++ b/chrome/browser/browser.cc @@ -2969,7 +2969,7 @@ void Browser::Observe(NotificationType type, // Handle EXTENSION_READY_FOR_INSTALL for last active normal browser. if (BrowserList::FindBrowserWithType(profile(), Browser::TYPE_NORMAL, - false) != this) + true) != this) break; // We only want to show the loading dialog for themes, but we don't want diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc index 9639a44..63e2d64 100644 --- a/chrome/browser/download/download_manager.cc +++ b/chrome/browser/download/download_manager.cc @@ -1478,7 +1478,7 @@ void DownloadManager::OpenChromeExtension(const FilePath& full_path, TabContents* contents = NULL; // Get last active normal browser of profile. Browser* last_active = BrowserList::FindBrowserWithType(profile_, - Browser::TYPE_NORMAL, false); + Browser::TYPE_NORMAL, true); if (last_active) contents = last_active->GetSelectedTabContents(); if (contents) { diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc index c5c22f6..f10c04a 100644 --- a/chrome/browser/extensions/extension_install_ui.cc +++ b/chrome/browser/extensions/extension_install_ui.cc @@ -308,7 +308,7 @@ void ExtensionInstallUI::ShowThemeInfoBar( // Get last active normal browser of profile. Browser* browser = BrowserList::FindBrowserWithType(profile, Browser::TYPE_NORMAL, - false); + true); if (!browser) return; |