diff options
author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-11 01:29:39 +0000 |
---|---|---|
committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-11 01:29:39 +0000 |
commit | 7258924d59592745795ec1c12eafb20a30625826 (patch) | |
tree | 5227f23676d7deb43d461bcca617a13ab41a15ed /chrome/browser | |
parent | 178f127ef64fb51620cee821156d7258c8719f01 (diff) | |
download | chromium_src-7258924d59592745795ec1c12eafb20a30625826.zip chromium_src-7258924d59592745795ec1c12eafb20a30625826.tar.gz chromium_src-7258924d59592745795ec1c12eafb20a30625826.tar.bz2 |
Unittest gardening on MacOS X:
- base/gfx/rect_unittest.cc had a typo
- base/waitable_event_watcher_unittest.cc enabled
- chrome/common/pref_member_unittest.cc enabled
- chrome/common/json_value_serializer_unittest.cc had a Windows-only
bit which currently works fine on Mac.
- These worked once an anonymous namespace was cleared up:
chrome/browser/history/query_parser_unittest.cc
chrome/browser/history/url_database_unittest.cc
chrome/common/json_value_serializer_unittest.cc
Some
required minor editting to remove anonymous namespaces for test
classes.
Review URL: http://codereview.chromium.org/20241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9539 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r-- | chrome/browser/history/query_parser_unittest.cc | 4 | ||||
-rw-r--r-- | chrome/browser/history/url_database_unittest.cc | 4 |
2 files changed, 2 insertions, 6 deletions
diff --git a/chrome/browser/history/query_parser_unittest.cc b/chrome/browser/history/query_parser_unittest.cc index 25d4f4e..6d425e91 100644 --- a/chrome/browser/history/query_parser_unittest.cc +++ b/chrome/browser/history/query_parser_unittest.cc @@ -7,8 +7,6 @@ #include "chrome/common/scoped_vector.h" #include "testing/gtest/include/gtest/gtest.h" -namespace { - class QueryParserTest : public testing::Test { public: struct TestData { @@ -22,8 +20,6 @@ class QueryParserTest : public testing::Test { QueryParser query_parser_; }; -}; // namespace - // Test helper: Convert a user query string to a SQLite query string. std::wstring QueryParserTest::QueryToString(const std::wstring& query) { std::wstring sqlite_query; diff --git a/chrome/browser/history/url_database_unittest.cc b/chrome/browser/history/url_database_unittest.cc index 9520fa7..a33829a 100644 --- a/chrome/browser/history/url_database_unittest.cc +++ b/chrome/browser/history/url_database_unittest.cc @@ -28,6 +28,8 @@ bool IsURLRowEqual(const URLRow& a, a.last_visit() - b.last_visit() <= TimeDelta::FromSeconds(1) && a.hidden() == b.hidden(); } + +} // namespace class URLDatabaseTest : public testing::Test, public URLDatabase { @@ -70,8 +72,6 @@ class URLDatabaseTest : public testing::Test, SqliteStatementCache* statement_cache_; }; -} // namespace - // Test add and query for the URL table in the HistoryDatabase TEST_F(URLDatabaseTest, AddURL) { // first, add two URLs |