diff options
| author | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-13 00:13:58 +0000 |
|---|---|---|
| committer | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-13 00:13:58 +0000 |
| commit | 8232162a3d5548dd187d5338fa7b7538102019c9 (patch) | |
| tree | d9da16a3a4d721ff3dff243f0f9aabbe0a51c510 /chrome/browser | |
| parent | b40f8640305e66d937ba4df7cc6c6ae4aad6f141 (diff) | |
| download | chromium_src-8232162a3d5548dd187d5338fa7b7538102019c9.zip chromium_src-8232162a3d5548dd187d5338fa7b7538102019c9.tar.gz chromium_src-8232162a3d5548dd187d5338fa7b7538102019c9.tar.bz2 | |
Native dialogs need to send GTK_RESPONSE_DELETE_EVENT on close
BUG=chromium-os:3211
TEST=Use html in bug, click "test" and then click close button.
App shouldn't freeze.
We will write new tests to cover this. The current ones bypass
the native dialog code and send the events directly. That's
why they didn't catch the regression.
Review URL: http://codereview.chromium.org/2053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/chromeos/native_dialog_window.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/chromeos/native_dialog_window.cc b/chrome/browser/chromeos/native_dialog_window.cc index 3c7cc72..485b917 100644 --- a/chrome/browser/chromeos/native_dialog_window.cc +++ b/chrome/browser/chromeos/native_dialog_window.cc @@ -128,7 +128,7 @@ void NativeDialogHost::WindowClosing() { // Disconnect the "destroy" signal because we are about to destroy // the dialog ourselves and no longer interested in it. g_signal_handler_disconnect(G_OBJECT(dialog_), destroy_signal_id_); - gtk_dialog_response(GTK_DIALOG(dialog_), GTK_RESPONSE_CLOSE); + gtk_dialog_response(GTK_DIALOG(dialog_), GTK_RESPONSE_DELETE_EVENT); } } |