diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-03 17:37:44 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-03 17:37:44 +0000 |
| commit | c50d0d442ccba35b3455b69e4114955d7e265e56 (patch) | |
| tree | 031a297d2e733b3a897087d450ab4d9aec36c858 /chrome/browser | |
| parent | e93657170f4dac1dcc6331ee6ebe4079c3d3de04 (diff) | |
| download | chromium_src-c50d0d442ccba35b3455b69e4114955d7e265e56.zip chromium_src-c50d0d442ccba35b3455b69e4114955d7e265e56.tar.gz chromium_src-c50d0d442ccba35b3455b69e4114955d7e265e56.tar.bz2 | |
Fixes regression where escape was not removing a newly bookmarked
page.
BUG=none
TEST=press the star button on a page you haven't bookmarked. The star
should light up. Press escape, the bubble should close and the
bookmark should be removed. Repeat with an existing bookmark and
make sure pressing escape doesn't remove the bookmark.
Review URL: http://codereview.chromium.org/40019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10803 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/browser.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc index c19d779..28d2a15 100644 --- a/chrome/browser/browser.cc +++ b/chrome/browser/browser.cc @@ -738,11 +738,12 @@ void Browser::BookmarkCurrentPage() { if (url.is_empty() || !url.is_valid()) return; + bool was_bookmarked = model->IsBookmarked(url); model->SetURLStarred(url, entry->title(), true); if (window_->IsActive()) { // Only show the bubble if the window is active, otherwise we may get into // weird situations were the bubble is deleted as soon as it is shown. - window_->ShowBookmarkBubble(url, model->IsBookmarked(url)); + window_->ShowBookmarkBubble(url, was_bookmarked); } } |