summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorifette@google.com <ifette@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-29 23:42:20 +0000
committerifette@google.com <ifette@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-29 23:42:20 +0000
commitd36e3c8e7dee006e32cbca1b61d3165d52320563 (patch)
tree881390ec794b061f0427a2cb625b4845582197d0 /chrome/browser
parent9079da8ed511524d03b2202d3582222701aa3059 (diff)
downloadchromium_src-d36e3c8e7dee006e32cbca1b61d3165d52320563.zip
chromium_src-d36e3c8e7dee006e32cbca1b61d3165d52320563.tar.gz
chromium_src-d36e3c8e7dee006e32cbca1b61d3165d52320563.tar.bz2
On line 138 of protocol_manager.cc we were converting a std::string
to a char*. The string could contain null bytes, which led to data loss and failures in safebrowsing. R=wtc BUG=1352561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1565 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/safe_browsing/protocol_manager.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc
index 3e6c95b..80ac3a1 100644
--- a/chrome/browser/safe_browsing/protocol_manager.cc
+++ b/chrome/browser/safe_browsing/protocol_manager.cc
@@ -135,7 +135,7 @@ void SafeBrowsingProtocolManager::GetFullHash(
fetcher->set_load_flags(net::LOAD_DISABLE_CACHE);
fetcher->set_request_context(Profile::GetDefaultRequestContext());
- fetcher->set_upload_data("text/plain", get_hash.data());
+ fetcher->set_upload_data("text/plain", get_hash);
fetcher->Start();
}