Plumb SSL connection information into the PageInfo model.

This plumbs two bits of information into the PageInfo model (the dialog
which results from clicking on the padlock icon): whether or not we
performed SSLv3 fallback and whether or not the server supported the
renegotiation extension.

It doesn't actually do anything with this information yet (except to add
histograms of them), pending future CLs.

BUG=none
TEST=none

http://codereview.chromium.org/2943001/show

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52079 0039d316-1c4b-4281-b951-d872f2087c98

9 files changed, 47 insertions, 19 deletions

diff --git a/chrome/browser/renderer_host/resource_dispatcher_host.cc b/chrome/browser/renderer_host/resource_dispatcher_host.cc
index 2d1e7fc..253c5ba 100644
--- a/chrome/browser/renderer_host/resource_dispatcher_host.cc
+++ b/chrome/browser/renderer_host/resource_dispatcher_host.cc
@@ -1038,14 +1038,16 @@ bool ResourceDispatcherHost::CompleteResponseStarted(URLRequest* request) {
         CertStore::GetSharedInstance()->StoreCert(request->ssl_info().cert,
                                                   info->child_id());
     response->response_head.security_info =
-        SSLManager::SerializeSecurityInfo(cert_id,
-                                          request->ssl_info().cert_status,
-                                          request->ssl_info().security_bits);
+        SSLManager::SerializeSecurityInfo(
+            cert_id, request->ssl_info().cert_status,
+            request->ssl_info().security_bits,
+            request->ssl_info().connection_status);
   } else {
     // We should not have any SSL state.
     DCHECK(!request->ssl_info().cert_status &&
            (request->ssl_info().security_bits == -1 ||
-           request->ssl_info().security_bits == 0));
+            request->ssl_info().security_bits == 0) &&
+           !request->ssl_info().connection_status);
   }
 
   NotifyResponseStarted(request, info->child_id());
@@ -1375,9 +1377,9 @@ void ResourceDispatcherHost::OnResponseCompleted(URLRequest* request) {
   if (ssl_info.cert != NULL) {
     int cert_id = CertStore::GetSharedInstance()->StoreCert(ssl_info.cert,
                                                             info->child_id());
-    security_info = SSLManager::SerializeSecurityInfo(cert_id,
-                                                      ssl_info.cert_status,
-                                                      ssl_info.security_bits);
+    security_info = SSLManager::SerializeSecurityInfo(
+        cert_id, ssl_info.cert_status, ssl_info.security_bits,
+        ssl_info.connection_status);
   }
 
   if (info->resource_handler()->OnResponseCompleted(info->request_id(),
diff --git a/chrome/browser/ssl/ssl_manager.cc b/chrome/browser/ssl/ssl_manager.cc
index dbff09e..d328d6e 100644
--- a/chrome/browser/ssl/ssl_manager.cc
+++ b/chrome/browser/ssl/ssl_manager.cc
@@ -59,11 +59,13 @@ void SSLManager::NotifySSLInternalStateChanged() {
 // static
 std::string SSLManager::SerializeSecurityInfo(int cert_id,
                                               int cert_status,
-                                              int security_bits) {
+                                              int security_bits,
+                                              int ssl_connection_status) {
   Pickle pickle;
   pickle.WriteInt(cert_id);
   pickle.WriteInt(cert_status);
   pickle.WriteInt(security_bits);
+  pickle.WriteInt(ssl_connection_status);
   return std::string(static_cast<const char*>(pickle.data()), pickle.size());
 }
 
@@ -71,13 +73,15 @@ std::string SSLManager::SerializeSecurityInfo(int cert_id,
 bool SSLManager::DeserializeSecurityInfo(const std::string& state,
                                          int* cert_id,
                                          int* cert_status,
-                                         int* security_bits) {
+                                         int* security_bits,
+                                         int* ssl_connection_status) {
   DCHECK(cert_id && cert_status && security_bits);
   if (state.empty()) {
     // No SSL used.
     *cert_id = 0;
     *cert_status = 0;
     *security_bits = -1;
+    *ssl_connection_status = 0;
     return false;
   }
 
@@ -85,7 +89,8 @@ bool SSLManager::DeserializeSecurityInfo(const std::string& state,
   void * iter = NULL;
   return pickle.ReadInt(&iter, cert_id) &&
          pickle.ReadInt(&iter, cert_status) &&
-         pickle.ReadInt(&iter, security_bits);
+         pickle.ReadInt(&iter, security_bits) &&
+         pickle.ReadInt(&iter, ssl_connection_status);
 }
 
 // static
@@ -134,11 +139,12 @@ void SSLManager::DidCommitProvisionalLoad(
   if (details->is_main_frame) {
     if (entry) {
       // Decode the security details.
-      int ssl_cert_id, ssl_cert_status, ssl_security_bits;
+      int ssl_cert_id, ssl_cert_status, ssl_security_bits, ssl_connection_status;
       DeserializeSecurityInfo(details->serialized_security_info,
                               &ssl_cert_id,
                               &ssl_cert_status,
-                              &ssl_security_bits);
+                              &ssl_security_bits,
+                              &ssl_connection_status);
 
       // We may not have an entry if this is a navigation to an initial blank
       // page. Reset the SSL information and add the new data we have.
@@ -146,6 +152,7 @@ void SSLManager::DidCommitProvisionalLoad(
       entry->ssl().set_cert_id(ssl_cert_id);
       entry->ssl().set_cert_status(ssl_cert_status);
       entry->ssl().set_security_bits(ssl_security_bits);
+      entry->ssl().set_connection_status(ssl_connection_status);
     }
     backend_.ShowPendingMessages();
   }
diff --git a/chrome/browser/ssl/ssl_manager.h b/chrome/browser/ssl/ssl_manager.h
index 7ee110e..e9916b3 100644
--- a/chrome/browser/ssl/ssl_manager.h
+++ b/chrome/browser/ssl/ssl_manager.h
@@ -56,11 +56,13 @@ class SSLManager : public NotificationObserver {
   // Convenience methods for serializing/deserializing the security info.
   static std::string SerializeSecurityInfo(int cert_id,
                                            int cert_status,
-                                           int security_bits);
+                                           int security_bits,
+                                           int connection_status);
   static bool DeserializeSecurityInfo(const std::string& state,
                                       int* cert_id,
                                       int* cert_status,
-                                      int* security_bits);
+                                      int* security_bits,
+                                      int* connection_status);
 
   // Returns "<organization_name> [<country>]".
   static std::wstring GetEVCertName(const net::X509Certificate& cert);
diff --git a/chrome/browser/tab_contents/navigation_entry.cc b/chrome/browser/tab_contents/navigation_entry.cc
index 4ce5bda..0fb4777 100644
--- a/chrome/browser/tab_contents/navigation_entry.cc
+++ b/chrome/browser/tab_contents/navigation_entry.cc
@@ -29,6 +29,7 @@ NavigationEntry::SSLStatus::SSLStatus()
       cert_id_(0),
       cert_status_(0),
       security_bits_(-1),
+      connection_status_(0),
       content_status_(NORMAL_CONTENT) {
 }
 
diff --git a/chrome/browser/tab_contents/navigation_entry.h b/chrome/browser/tab_contents/navigation_entry.h
index 1faee15..341ebeb 100644
--- a/chrome/browser/tab_contents/navigation_entry.h
+++ b/chrome/browser/tab_contents/navigation_entry.h
@@ -102,6 +102,13 @@ class NavigationEntry {
       return (content_status_ & RAN_INSECURE_CONTENT) != 0;
     }
 
+    void set_connection_status(int connection_status) {
+        connection_status_ = connection_status;
+    }
+    int connection_status() const {
+      return connection_status_;
+    }
+
     // Raw accessors for all the content status flags. This contains a
     // combination of any of the ContentStatusFlags defined above. It is used
     // by some tests for checking and for certain copying. Use the per-status
@@ -119,6 +126,7 @@ class NavigationEntry {
     int cert_id_;
     int cert_status_;
     int security_bits_;
+    int connection_status_;
     int content_status_;
 
     // Copy and assignment is explicitly allowed for this class.
diff --git a/chrome/browser/tab_contents/provisional_load_details.cc b/chrome/browser/tab_contents/provisional_load_details.cc
index f144d0a..3bea977 100644
--- a/chrome/browser/tab_contents/provisional_load_details.cc
+++ b/chrome/browser/tab_contents/provisional_load_details.cc
@@ -19,9 +19,11 @@ ProvisionalLoadDetails::ProvisionalLoadDetails(bool is_main_frame,
         ssl_cert_id_(0),
         ssl_cert_status_(0),
         ssl_security_bits_(-1),
+        ssl_connection_status_(0),
         is_content_filtered_(is_content_filtered) {
   SSLManager::DeserializeSecurityInfo(security_info,
                                       &ssl_cert_id_,
                                       &ssl_cert_status_,
-                                      &ssl_security_bits_);
+                                      &ssl_security_bits_,
+                                      &ssl_connection_status_);
 }
diff --git a/chrome/browser/tab_contents/provisional_load_details.h b/chrome/browser/tab_contents/provisional_load_details.h
index ce4f5da..4f6abad 100644
--- a/chrome/browser/tab_contents/provisional_load_details.h
+++ b/chrome/browser/tab_contents/provisional_load_details.h
@@ -43,6 +43,8 @@ class ProvisionalLoadDetails {
 
   int ssl_security_bits() const { return ssl_security_bits_; }
 
+  int ssl_connection_status() const { return ssl_connection_status_; }
+
   bool is_content_filtered() const { return is_content_filtered_; }
 
  private:
@@ -53,6 +55,7 @@ class ProvisionalLoadDetails {
   int ssl_cert_id_;
   int ssl_cert_status_;
   int ssl_security_bits_;
+  int ssl_connection_status_;
   bool is_content_filtered_;
 
   DISALLOW_COPY_AND_ASSIGN(ProvisionalLoadDetails);
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 101d43f..c912965 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -1169,14 +1169,16 @@ void RenderViewContextMenu::ExecuteCommand(int id) {
       // Deserialize the SSL info.
       NavigationEntry::SSLStatus ssl;
       if (!params_.security_info.empty()) {
-        int cert_id, cert_status, security_bits;
+        int cert_id, cert_status, security_bits, connection_status;
         SSLManager::DeserializeSecurityInfo(params_.security_info,
                                             &cert_id,
                                             &cert_status,
-                                            &security_bits);
+                                            &security_bits,
+                                            &connection_status);
         ssl.set_cert_id(cert_id);
         ssl.set_cert_status(cert_status);
         ssl.set_security_bits(security_bits);
+        ssl.set_connection_status(connection_status);
       }
       source_tab_contents_->ShowPageInfo(params_.frame_url, ssl,
                                          false);  // Don't show the history.
diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc
index f0dd1d5..963ed7b 100644
--- a/chrome/browser/tab_contents/tab_contents.cc
+++ b/chrome/browser/tab_contents/tab_contents.cc
@@ -2032,10 +2032,11 @@ void TabContents::DidLoadResourceFromMemoryCache(
     const std::string& main_frame_origin,
     const std::string& security_info) {
   // Send out a notification that we loaded a resource from our memory cache.
-  int cert_id = 0, cert_status = 0, security_bits = 0;
+  int cert_id = 0, cert_status = 0, security_bits = 0, connection_status = 0;
   SSLManager::DeserializeSecurityInfo(security_info,
                                       &cert_id, &cert_status,
-                                      &security_bits);
+                                      &security_bits,
+                                      &connection_status);
   LoadFromMemoryCacheDetails details(url, frame_origin, main_frame_origin,
                                      GetRenderProcessHost()->id(), cert_id,
                                      cert_status);