diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-30 23:00:49 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-30 23:00:49 +0000 |
| commit | b0c08fdf98bb655b7a99a1f13ec26b355298744a (patch) | |
| tree | 643cb941756632a3b5527302501dff18c5231101 /chrome/browser | |
| parent | 4ea00e8c3830cd4b648d07adbe3328c70f327bf7 (diff) | |
| download | chromium_src-b0c08fdf98bb655b7a99a1f13ec26b355298744a.zip chromium_src-b0c08fdf98bb655b7a99a1f13ec26b355298744a.tar.gz chromium_src-b0c08fdf98bb655b7a99a1f13ec26b355298744a.tar.bz2 | |
Remove a NOTREACHED() in plugin code that can be reached.
It was contributing to test flakiness. I also updated a comment explaining why the code doesn't kill the plugin process.
TEST=none
http://crbug.com/18108
Review URL: http://codereview.chromium.org/159602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22116 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_win.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_win.cc b/chrome/browser/renderer_host/render_widget_host_view_win.cc index 5e0f535..554574e 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_win.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_win.cc @@ -325,8 +325,8 @@ void RenderWidgetHostViewWin::MovePluginWindows( ::ShowWindow(window, SW_SHOW); // Window was created hidden. } else if (::GetParent(parent) != m_hWnd) { // The renderer should only be trying to move windows that are children - // of its render widget window. - NOTREACHED(); + // of its render widget window. However, this may happen as a result of + // a race condition, so we ignore it and not kill the plugin process. continue; } |