diff options
author | mattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 19:51:20 +0000 |
---|---|---|
committer | mattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 19:51:20 +0000 |
commit | 6d749fe8c0dbc9ba66e64c1c919c847792ce315a (patch) | |
tree | 52326e8fe8958ba02356126d382840ed734e5008 /chrome/browser | |
parent | 8cc419448037675e5742586429bb6c00606ce8f9 (diff) | |
download | chromium_src-6d749fe8c0dbc9ba66e64c1c919c847792ce315a.zip chromium_src-6d749fe8c0dbc9ba66e64c1c919c847792ce315a.tar.gz chromium_src-6d749fe8c0dbc9ba66e64c1c919c847792ce315a.tar.bz2 |
Add asserts to PipeReaderTest to avoid crashing on reading less than expected.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/4499004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65240 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
-rw-r--r-- | chrome/browser/chromeos/pipe_reader_unittest.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/chromeos/pipe_reader_unittest.cc b/chrome/browser/chromeos/pipe_reader_unittest.cc index 3646b30..f45fe50 100644 --- a/chrome/browser/chromeos/pipe_reader_unittest.cc +++ b/chrome/browser/chromeos/pipe_reader_unittest.cc @@ -63,11 +63,13 @@ TEST_F(PipeReaderTest, SuccessfulMultiLineReadTest) { PipeReader reader(pipe_name); // asking for more should still just return the amount that was written. std::string my_foo = reader.Read(5 * line.length()); + ASSERT_GT(my_foo.length(), 0U); EXPECT_EQ(my_foo[my_foo.length() - 1], '\n'); my_foo.resize(my_foo.length() - 1); EXPECT_EQ(my_foo, foo); std::string my_boo = reader.Read(5 * line.length()); + ASSERT_GT(my_boo.length(), 0U); EXPECT_EQ(my_boo[my_boo.length() - 1], '\n'); my_boo.resize(my_boo.length() - 1); EXPECT_EQ(my_boo, boo); @@ -97,6 +99,7 @@ TEST_F(PipeReaderTest, SuccessfulMultiLineReadNoEndingNewlineTest) { PipeReader reader(pipe_name); // asking for more should still just return the amount that was written. std::string my_foo = reader.Read(5 * line.length()); + ASSERT_GT(my_foo.length(), 0U); EXPECT_EQ(my_foo[my_foo.length() - 1], '\n'); my_foo.resize(my_foo.length() - 1); EXPECT_EQ(my_foo, foo); |