diff options
| author | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-24 20:24:48 +0000 |
|---|---|---|
| committer | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-24 20:24:48 +0000 |
| commit | 3a76ec1999dc11db01da59a322b0b9f2eceba3b2 (patch) | |
| tree | 7ecc0eb0c05a3795a245626efcd1ae4f93199983 /chrome/chrome.gyp | |
| parent | 2d6e5029ff051a4bb7632c99b575170ba93a0a62 (diff) | |
| download | chromium_src-3a76ec1999dc11db01da59a322b0b9f2eceba3b2.zip chromium_src-3a76ec1999dc11db01da59a322b0b9f2eceba3b2.tar.gz chromium_src-3a76ec1999dc11db01da59a322b0b9f2eceba3b2.tar.bz2 | |
Use chrome/base synchronization primitives and threads instead of
pthreads in SyncerThread. The old pthread impl can be used by
specifying --syncer-thread-pthreads for comparison until we
settle fully on the final impl (I have a MessageLoop-based impl
in progress).
The default SyncerThread is as close to the pthreads-impl semantics as
I could get, with one exception: it does not offer a time-out
when calling Stop(), because it greatly simplifies the implementation.
I first implemented it *with* the timeout, and for sake of
experimentation while this is in shuffle I am checking it in
as SyncerThreadTimedStop, available by using --syncer-thread-timed-stop. I'm not sure which we want ultimately, but it's useful to have around when building the MessageLoop based impl.
I had to refactor the interface slightly to allow multiple implementations,
I think it will be quite useful while working on the MessageLoop impl.
Added several tests to SyncerThreadUnittest, which all impls now pass (
just pass the command line flag to try each out).
TEST=SyncerThreadTest, SyncerThreadWithSyncerTest, integration tests
Review URL: http://codereview.chromium.org/214033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 80c834b..0587c15 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -4589,6 +4589,7 @@ '../third_party/libjingle/libjingle.gyp:libjingle', '../third_party/protobuf2/protobuf.gyp:protobuf', '../third_party/sqlite/sqlite.gyp:sqlite', + 'common', 'notifier', 'sync', ], @@ -6567,6 +6568,10 @@ 'browser/sync/engine/syncer_status.h', 'browser/sync/engine/syncer_thread.cc', 'browser/sync/engine/syncer_thread.h', + 'browser/sync/engine/syncer_thread_timed_stop.cc', + 'browser/sync/engine/syncer_thread_timed_stop.h', + 'browser/sync/engine/syncer_thread_pthreads.cc', + 'browser/sync/engine/syncer_thread_pthreads.h', 'browser/sync/engine/syncer_types.h', 'browser/sync/engine/syncer_util.cc', 'browser/sync/engine/syncer_util.h', |