diff options
| author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-02 17:56:29 +0000 |
|---|---|---|
| committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-02 17:56:29 +0000 |
| commit | a4e63abbe3c3eae27c67690ebcbb76f48c17c88a (patch) | |
| tree | ddf83822ae0983eab6a59f3a7317cd3f004c034c /chrome/chrome.gyp | |
| parent | e0eb4a9bd87048ef2008aaf89916b466026c6c64 (diff) | |
| download | chromium_src-a4e63abbe3c3eae27c67690ebcbb76f48c17c88a.zip chromium_src-a4e63abbe3c3eae27c67690ebcbb76f48c17c88a.tar.gz chromium_src-a4e63abbe3c3eae27c67690ebcbb76f48c17c88a.tar.bz2 | |
Create the PopupView from the EditView, not the PopupModel.
It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model).
This does what makes more sense, create platform specific instances from platform specific code. The AutocompleteEditView now creates the AutocompletePopupView. The AutocompletePopupView now creates the AutocompletePopupModel.
This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer. This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h. This is sad but neccessary.
This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance.
Review URL: http://codereview.chromium.org/28313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10707 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 3756118..598c43f 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -334,6 +334,7 @@ 'browser/autocomplete/autocomplete_popup_model.h', 'browser/autocomplete/autocomplete_popup_view.h', 'browser/autocomplete/autocomplete_popup_view_win.cc', + 'browser/autocomplete/autocomplete_popup_view_win.h', 'browser/autocomplete/edit_drop_target.cc', 'browser/autocomplete/edit_drop_target.h', 'browser/autocomplete/history_contents_provider.cc', |