diff options
| author | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-07 20:18:28 +0000 |
|---|---|---|
| committer | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-07 20:18:28 +0000 |
| commit | 0bfa713f7ae0bd154e7a0246413561de64d8c84d (patch) | |
| tree | 1eb0198e7a91815be2a8cc7007b53b11e241e6fe /chrome/chrome.gyp | |
| parent | 70771b35915b066928ac79c8a5ba4b950e4d74ec (diff) | |
| download | chromium_src-0bfa713f7ae0bd154e7a0246413561de64d8c84d.zip chromium_src-0bfa713f7ae0bd154e7a0246413561de64d8c84d.tar.gz chromium_src-0bfa713f7ae0bd154e7a0246413561de64d8c84d.tar.bz2 | |
Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.
JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac.
AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view.
The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text.
Review URL: http://codereview.chromium.org/63033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index ad067fe..eb4f0c0 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -382,6 +382,9 @@ 'browser/alternate_nav_url_fetcher.h', 'browser/app_controller_mac.h', 'browser/app_controller_mac.mm', + 'browser/app_modal_dialog.cc', + 'browser/app_modal_dialog.h', + 'browser/app_modal_dialog_win.cc', 'browser/app_modal_dialog_queue.cc', 'browser/app_modal_dialog_queue.h', 'browser/autocomplete/autocomplete.cc', @@ -792,12 +795,8 @@ 'browser/importer/mork_reader.h', 'browser/jankometer.cc', 'browser/jankometer.h', - 'browser/js_before_unload_handler.h', - 'browser/js_before_unload_handler_win.cc', - 'browser/js_before_unload_handler_win.h', + 'browser/jsmessage_box_handler.cc', 'browser/jsmessage_box_handler.h', - 'browser/jsmessage_box_handler_win.cc', - 'browser/jsmessage_box_handler_win.h', 'browser/load_from_memory_cache_details.h', 'browser/load_notification_details.h', 'browser/location_bar.h', @@ -1163,6 +1162,8 @@ 'browser/views/infobars/infobars.h', 'browser/views/input_window.cc', 'browser/views/input_window.h', + 'browser/views/jsmessage_box_dialog.cc', + 'browser/views/jsmessage_box_dialog.h', 'browser/views/keyword_editor_view.cc', 'browser/views/keyword_editor_view.h', 'browser/views/location_bar_view.cc', @@ -2612,7 +2613,6 @@ 'views/widget/widget_gtk.h', 'views/widget/widget_win.cc', 'views/widget/widget_win.h', - 'views/window/app_modal_dialog_delegate.h', 'views/window/client_view.cc', 'views/window/client_view.h', 'views/window/custom_frame_view.cc', |