diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-10 00:06:52 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-10 00:06:52 +0000 |
| commit | 871aae38baabc22b34a2cf2c2a7e9f1a49dcb4de (patch) | |
| tree | 9aeca6d3612bc12d26d2b5441644f2dcb53d486a /chrome/chrome.gyp | |
| parent | 5ef3a96c126beb9b514afeb7033cb911e2f9bcca (diff) | |
| download | chromium_src-871aae38baabc22b34a2cf2c2a7e9f1a49dcb4de.zip chromium_src-871aae38baabc22b34a2cf2c2a7e9f1a49dcb4de.tar.gz chromium_src-871aae38baabc22b34a2cf2c2a7e9f1a49dcb4de.tar.bz2 | |
Add return values to SyncerCommand
This is part 1 of 3 in a series of patches to remove the unnecessary
SYNC_CYCLE_CONTINUATION sync cycle that follows every sync commit.
In this patch, we add a return value to all SyncerCommands. This will
make it easier for us to tell when a command has failed, and why.
Currently, the error detection does not work very well. We don't have
much support for errors that occur on worker threads. Many commands will
return an error only in case of directory lookup failure, but return
NO_ERROR otherwise.
This is OK because we're not aiming to fully implement error detection
in this commit. This provides a base we can build on in future commits.
BUG=94670,109422
TEST=
Review URL: http://codereview.chromium.org/9113024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116963 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 650cfab..59db3d397c 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -1,4 +1,4 @@ -# Copyright (c) 2011 The Chromium Authors. All rights reserved. +# Copyright (c) 2012 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. { @@ -262,6 +262,8 @@ 'sources': [ 'browser/sync/engine/syncapi_internal.cc', 'browser/sync/engine/syncapi_internal.h', + 'browser/sync/internal_api/includes/syncer_error.cc', + 'browser/sync/internal_api/includes/syncer_error.h', 'browser/sync/internal_api/includes/unrecoverable_error_handler.h', 'browser/sync/internal_api/base_node.cc', 'browser/sync/internal_api/base_node.h', |