diff options
| author | glider <glider@chromium.org> | 2014-12-18 06:09:57 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-18 14:11:51 +0000 |
| commit | bcecbe6314be4e01e99b4e48306ec81f78b0c21b (patch) | |
| tree | 097b7614d2f889f8c9a1525183f017e91eac6d90 /chrome/chrome.gyp | |
| parent | 9ecc06bdcb5fbd1dcab8b35d7dcbe0b383b5d410 (diff) | |
| download | chromium_src-bcecbe6314be4e01e99b4e48306ec81f78b0c21b.zip chromium_src-bcecbe6314be4e01e99b4e48306ec81f78b0c21b.tar.gz chromium_src-bcecbe6314be4e01e99b4e48306ec81f78b0c21b.tar.bz2 | |
Reland https://codereview.chromium.org/292153006 (Enable mac_strip_release under ASan on OSX. Remove the .saves files) with minor changes.
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
This CL makes the buildsystem strip only the debug info from the ASan binaries.
As a result, the .saves files aren't necessary anymore.
This CL deletes them and turns mac_strip_release on for ASan
builds.
In order to keep the __asan_default_options symbol in every ASan executable,
we're only stripping the debug info from them (unlike in https://codereview.chromium.org/728233003/,
which has been reverted because __asan_default_options had been stripped).
BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/814033002
Cr-Commit-Position: refs/heads/master@{#309005}
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index ad1b240..e70fa9a 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -262,12 +262,6 @@ 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)', }, }], - ['asan==1', { - 'xcode_settings': { - # Override the outer definition of CHROMIUM_STRIP_SAVE_FILE. - 'CHROMIUM_STRIP_SAVE_FILE': 'app/app_asan.saves', - }, - }], ['component=="shared_library"', { 'xcode_settings': { 'LD_RUNPATH_SEARCH_PATHS': [ |