diff options
| author | wyck@chromium.org <wyck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-08 17:55:55 +0000 |
|---|---|---|
| committer | wyck@chromium.org <wyck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-08 17:55:55 +0000 |
| commit | a37d7ec1af822aa3524308c58c5160e3bf117965 (patch) | |
| tree | a1d76129ea834e42884f31347b092cf0fc5f6e5f /chrome/chrome_browser.gypi | |
| parent | eeb7bdff95f4db2384885384ca56ce05494027fb (diff) | |
| download | chromium_src-a37d7ec1af822aa3524308c58c5160e3bf117965.zip chromium_src-a37d7ec1af822aa3524308c58c5160e3bf117965.tar.gz chromium_src-a37d7ec1af822aa3524308c58c5160e3bf117965.tar.bz2 | |
Refactoring so that there is no BaseTabStrip in BrowserView.
There are very few reasons that the BrowserView needs to know anything specific about the TabStrip. Most of them have to do with drag and drop.
So we introduce in this patch, an AbstractTabStripView interface that is the BrowserView's interface to the tab strip (instead of BaseTabStrip). Furthermore, we acknowledge that the View and the Controller are tightly coupled (they know about each other) and are therefore bound together at creation time inside the factory function rather than by the caller of the factory function (which would have been the BrowserView.)
1) The extensions need to restrict the ability to move/remove tabs when a drop operation is active. So we have IsTabStripEditable() and IsTabStripCloseable().
2) The only other reason to know about the internals seems to be some notification of loading animations. So we have UpdateLoadingAnimations().
Ideally, some day a tab strip can just be a view from the browser's perspective. For now, we still need these three methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6597107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77299 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 62359ec..f86234ae 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -3150,6 +3150,7 @@ 'browser/ui/views/tab_contents/tab_contents_view_win.h', 'browser/ui/views/tab_icon_view.cc', 'browser/ui/views/tab_icon_view.h', + 'browser/ui/views/tabs/abstract_tab_strip_view.h', 'browser/ui/views/tabs/base_tab.cc', 'browser/ui/views/tabs/base_tab.h', 'browser/ui/views/tabs/base_tab_strip.cc', @@ -4042,6 +4043,7 @@ ['include', '^browser/ui/views/tab_contents/tab_contents_view_gtk.h'], ['include', '^browser/ui/views/tab_icon_view.cc'], ['include', '^browser/ui/views/tab_icon_view.h'], + ['include', '^browser/ui/views/tabs/abstract_tab_strip_view.h'], ['include', '^browser/ui/views/tabs/base_tab.cc'], ['include', '^browser/ui/views/tabs/base_tab.h'], ['include', '^browser/ui/views/tabs/base_tab_strip.cc'], |