diff options
author | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-21 19:34:49 +0000 |
---|---|---|
committer | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-21 19:34:49 +0000 |
commit | 1f18184a07252103a8cd9652d64de749f41ef09f (patch) | |
tree | 7e0c5eb9dea2890d8231eb7ad69dec318ac6e610 /chrome/chrome_browser.gypi | |
parent | 348b9bc12d4e2ccd03a7fbcb327a3975207a5fec (diff) | |
download | chromium_src-1f18184a07252103a8cd9652d64de749f41ef09f.zip chromium_src-1f18184a07252103a8cd9652d64de749f41ef09f.tar.gz chromium_src-1f18184a07252103a8cd9652d64de749f41ef09f.tar.bz2 |
Refactor SSLClientAuthHandler and certificate selection
This cleans up much of the code involved in displaying a certificate selection
dialog to the user.
- Adds a new inner class to RenderViewHostDelegate (later to be populated
with more SSL things).
- Adds a helper class for TabContents' implementation.
- Moves the certificate dialogs themselves to have a common entry point.
- Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the
TabContents implementation displaying the dialogs.
- Picks the correct parent window for the dialog on all platforms, instead of
relying on BrowserList::GetLastActive
- Makes the OS X implementation use an asynchronous sheet, now that we know the
parent.
- Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity.
R=agl,brettw,mark
BUG=148
TEST=selecting client certificates still works
Review URL: http://codereview.chromium.org/2823038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
-rw-r--r-- | chrome/chrome_browser.gypi | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index ffa9db3..57e2996 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -946,6 +946,7 @@ 'browser/cocoa/side_tab_strip_view.mm', 'browser/cocoa/simple_content_exceptions_window_controller.h', 'browser/cocoa/simple_content_exceptions_window_controller.mm', + 'browser/cocoa/ssl_client_certificate_selector.mm', 'browser/cocoa/status_bubble_mac.h', 'browser/cocoa/status_bubble_mac.mm', 'browser/cocoa/status_icons/status_icon_mac.h', @@ -1620,6 +1621,7 @@ 'browser/gtk/sad_tab_gtk.h', 'browser/gtk/slide_animator_gtk.cc', 'browser/gtk/slide_animator_gtk.h', + 'browser/gtk/ssl_client_certificate_selector.cc', 'browser/gtk/status_bubble_gtk.cc', 'browser/gtk/status_bubble_gtk.h', 'browser/gtk/status_icons/status_icon_gtk.h', @@ -2260,9 +2262,6 @@ 'browser/ssl/ssl_cert_error_handler.cc', 'browser/ssl/ssl_cert_error_handler.h', 'browser/ssl/ssl_client_auth_handler.cc', - 'browser/ssl/ssl_client_auth_handler_mac.mm', - 'browser/ssl/ssl_client_auth_handler_win.cc', - 'browser/ssl/ssl_client_auth_handler_gtk.cc', 'browser/ssl/ssl_client_auth_handler.h', 'browser/ssl/ssl_error_handler.cc', 'browser/ssl/ssl_error_handler.h', @@ -2277,6 +2276,7 @@ 'browser/ssl/ssl_policy_backend.cc', 'browser/ssl/ssl_policy_backend.h', 'browser/ssl/ssl_request_info.h', + 'browser/ssl_client_certificate_selector.h', 'browser/status_bubble.h', 'browser/status_icons/status_tray.cc', 'browser/status_icons/status_tray.h', @@ -2405,6 +2405,8 @@ 'browser/tab_contents/tab_contents.h', 'browser/tab_contents/tab_contents_delegate.cc', 'browser/tab_contents/tab_contents_delegate.h', + 'browser/tab_contents/tab_contents_ssl_helper.cc', + 'browser/tab_contents/tab_contents_ssl_helper.h', 'browser/tab_contents/tab_contents_view.cc', 'browser/tab_contents/tab_contents_view.h', 'browser/tab_contents/tab_contents_view_gtk.cc', @@ -2728,6 +2730,7 @@ 'browser/views/sad_tab_view.h', 'browser/views/select_file_dialog.cc', 'browser/views/shell_dialogs_win.cc', + 'browser/views/ssl_client_certificate_selector_win.cc', 'browser/views/status_bubble_views.cc', 'browser/views/status_bubble_views.h', 'browser/views/status_icons/status_icon_win.cc', @@ -3458,6 +3461,7 @@ ['include', '^browser/gtk/popup_blocked_animation_gtk.cc'], ['include', '^browser/gtk/repost_form_warning_gtk.cc'], ['include', '^browser/gtk/repost_form_warning_gtk.h'], + ['include', '^browser/gtk/ssl_client_certificate_selector.cc'], ['include', '^browser/gtk/tab_contents_drag_source.cc'], ['include', '^browser/gtk/tab_contents_drag_source.h'], ['include', '^browser/gtk/task_manager_gtk.cc'], |