diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-26 21:45:34 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-26 21:45:34 +0000 |
| commit | 96788b0612875c0d12584757b63f02112e9541a7 (patch) | |
| tree | d7eb82156c83b850d2714110dd7d8bb7aad60c41 /chrome/chrome_browser.gypi | |
| parent | 21ca7bf8f06e3b6e608f26eed8dce30515721b86 (diff) | |
| download | chromium_src-96788b0612875c0d12584757b63f02112e9541a7.zip chromium_src-96788b0612875c0d12584757b63f02112e9541a7.tar.gz chromium_src-96788b0612875c0d12584757b63f02112e9541a7.tar.bz2 | |
Mac: First run bubble.
Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.
Move some l10n stuff to l10n_util and use that, too.
Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())
BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.
Review URL: http://codereview.chromium.org/2822026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index ec70636..5c5946e 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -586,6 +586,8 @@ 'browser/cocoa/background_gradient_view.mm', 'browser/cocoa/background_tile_view.h', 'browser/cocoa/background_tile_view.mm', + 'browser/cocoa/base_bubble_controller.h', + 'browser/cocoa/base_bubble_controller.mm', 'browser/cocoa/base_view.h', 'browser/cocoa/base_view.mm', 'browser/cocoa/browser_window_factory.mm', @@ -745,6 +747,8 @@ 'browser/cocoa/find_bar_view.mm', 'browser/cocoa/find_pasteboard.h', 'browser/cocoa/find_pasteboard.mm', + 'browser/cocoa/first_run_bubble_controller.h', + 'browser/cocoa/first_run_bubble_controller.mm', 'browser/cocoa/first_run_dialog.h', 'browser/cocoa/first_run_dialog.mm', 'browser/cocoa/floating_bar_backing_view.h', @@ -2089,6 +2093,8 @@ 'browser/search_engines/template_url_prepopulate_data.h', 'browser/search_engines/template_url_table_model.cc', 'browser/search_engines/template_url_table_model.h', + 'browser/search_engines/util.cc', + 'browser/search_engines/util.h', 'browser/session_startup_pref.cc', 'browser/session_startup_pref.h', 'browser/sessions/base_session_service.cc', @@ -2927,6 +2933,7 @@ 'app/nibs/ExtensionInstalledBubble.xib', 'app/nibs/ExtensionInstallPrompt.xib', 'app/nibs/ExtensionInstallPromptNoWarnings.xib', + 'app/nibs/FirstRunBubble.xib', 'app/nibs/FirstRunDialog.xib', 'app/nibs/FontLanguageSettings.xib', 'app/nibs/GeolocationExceptionsWindow.xib', |