diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 23:25:52 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 23:25:52 +0000 |
| commit | 7893a989c3e8cfa8f9cc25547025d541c1205ef4 (patch) | |
| tree | 2ae568e48c773ec1c1bf614ca5ba326f9327d0d7 /chrome/chrome_browser.gypi | |
| parent | 59a10b95b43a0b78ec3153ed21f2b1181a4a947e (diff) | |
| download | chromium_src-7893a989c3e8cfa8f9cc25547025d541c1205ef4.zip chromium_src-7893a989c3e8cfa8f9cc25547025d541c1205ef4.tar.gz chromium_src-7893a989c3e8cfa8f9cc25547025d541c1205ef4.tar.bz2 | |
Revert 35735 - Relanding the language detection code.
Still causes redness on the reliability bot.
The code would crash if multiple PageContents notifications
were received rapidly. The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unittests to validate these cases in web_contents_unittest.cc.
Note that patch set 1 is the original patch, patch set 2 contains the new changes.
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unittests.
Review URL: http://codereview.chromium.org/504051
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/523149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35753 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rwxr-xr-x | chrome/chrome_browser.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 5d1f3ec..5117946 100755 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -308,8 +308,6 @@ 'browser/chromeos/usb_mount_observer.h', 'browser/chromeos/version_loader.cc', 'browser/chromeos/version_loader.h', - 'browser/cld_helper.cc', - 'browser/cld_helper.h', 'browser/cocoa/about_ipc_bridge.h', 'browser/cocoa/about_ipc_bridge.mm', 'browser/cocoa/about_ipc_controller.h', |