diff options
| author | hajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-14 08:39:38 +0000 |
|---|---|---|
| committer | hajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-14 08:39:38 +0000 |
| commit | 462e90901f8079a985ed3beda224bcee63ca6cf4 (patch) | |
| tree | 11aa8bc8ace98888220c40f50e3cf0ba3dff7987 /chrome/chrome_browser.gypi | |
| parent | 692280dd64a5d85f38ae2138c44854af847f25a2 (diff) | |
| download | chromium_src-462e90901f8079a985ed3beda224bcee63ca6cf4.zip chromium_src-462e90901f8079a985ed3beda224bcee63ca6cf4.tar.gz chromium_src-462e90901f8079a985ed3beda224bcee63ca6cf4.tar.bz2 | |
Translate: Filter and record languages whose names Chrome doesn't show
1) Filter undisplayable languages (, whose names Chrome doesn't show)
2) Record undisplayable languages
3) Rename TranslateManagerMetrics to TranslateBrowserMetrics
4) Obsolete Translate.ServerReportedUnsupportedLanguage
The Tranlate server sends the language list, and this may include a language UI can't deal with for lack of the resource. This CL filters such languages and reports them by UMA 'Translate.UndisplayableLanguage'. This UMA can be substitute of 'Translate.ServerReportedUnsupportedLanguage'. 'Translate.ServerReportedUnsupportedLanguage' is no longer needed and I made it obsolete.
Originally, we intended to implement the other UMA 'Translate.UnavailableLanguage' https://chromiumcodereview.appspot.com/15311006/, but changed our direction.
Moreover, Translate.ServerReportedUnsupportedLanguage was supposed to be removed in that CL, but I kept it unchanged accidentally.
BUG=242142
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/15987004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206371 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 94f05e3..668b682 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -2252,6 +2252,8 @@ 'browser/translate/page_translated_details.h', 'browser/translate/translate_accept_languages.h', 'browser/translate/translate_accept_languages.cc', + 'browser/translate/translate_browser_metrics.cc', + 'browser/translate/translate_browser_metrics.h', 'browser/translate/translate_error_details.h', 'browser/translate/translate_event_details.cc', 'browser/translate/translate_event_details.h', @@ -2261,8 +2263,6 @@ 'browser/translate/translate_language_list.h', 'browser/translate/translate_manager.cc', 'browser/translate/translate_manager.h', - 'browser/translate/translate_manager_metrics.cc', - 'browser/translate/translate_manager_metrics.h', 'browser/translate/translate_prefs.cc', 'browser/translate/translate_prefs.h', 'browser/translate/translate_tab_helper.cc', |