diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-28 22:27:04 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-28 22:27:04 +0000 |
| commit | 25da2f324b3ff67bde74b4d339429c582e54147a (patch) | |
| tree | 008d64a26354cb330735f67a88fa522be599d5c9 /chrome/chrome_browser.gypi | |
| parent | c417b76be98fcfb19a743f7f044163cc7b5d7ef2 (diff) | |
| download | chromium_src-25da2f324b3ff67bde74b4d339429c582e54147a.zip chromium_src-25da2f324b3ff67bde74b4d339429c582e54147a.tar.gz chromium_src-25da2f324b3ff67bde74b4d339429c582e54147a.tar.bz2 | |
Revert 60845 (check perms failure) - Added UI for clearing Chrome Sync data
- Created 2 tabs, one for for clearing local browsing data, one for clearing server data
- Refactored the old local browsing code to use a grid layout rather than less-wieldy math
- Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress
- Clear server tab will be behind a flag until I deploy the server endpoint
- Retained old clearing behavior: dialog closes on successful lear
- Clear server UI only visible if user is syncing
Outstanding issues:
- Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix
- Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again
BUG=54349
TEST=Clear from UI, or run sync backend tests checked in for issue 54280
Review URL: http://codereview.chromium.org/3412032
TBR=raz@chromium.org
Review URL: http://codereview.chromium.org/3552001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60857 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 24c5aa8..7575488 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -2847,12 +2847,6 @@ 'browser/views/chrome_views_delegate.h', 'browser/views/clear_browsing_data.cc', 'browser/views/clear_browsing_data.h', - 'browser/views/clear_browsing_data_view.cc', - 'browser/views/clear_browsing_data_view.h', - 'browser/views/clear_data_view.cc', - 'browser/views/clear_data_view.h', - 'browser/views/clear_server_data.cc', - 'browser/views/clear_server_data.h', 'browser/views/collected_cookies_win.cc', 'browser/views/collected_cookies_win.h', 'browser/views/confirm_message_box_dialog.cc', |