diff options
| author | ahendrickson@chromium.org <ahendrickson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-23 19:15:01 +0000 |
|---|---|---|
| committer | ahendrickson@chromium.org <ahendrickson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-23 19:15:01 +0000 |
| commit | 4cd82f72da57dac8a4b810d8a99fbe5b379cf593 (patch) | |
| tree | 5c503dfa4605672086765819a2af1ab9f669dd2e /chrome/chrome_browser.gypi | |
| parent | 088e6a3814c7de976650e8ad2b5cb075656d8665 (diff) | |
| download | chromium_src-4cd82f72da57dac8a4b810d8a99fbe5b379cf593.zip chromium_src-4cd82f72da57dac8a4b810d8a99fbe5b379cf593.tar.gz chromium_src-4cd82f72da57dac8a4b810d8a99fbe5b379cf593.tar.bz2 | |
Part 2 of downloads data flow refactor.
Reduced the lifetime of DownloadCreateInfo.
DownloadCreateInfo now only lives until DownloadFileManager::CreateDownloadFile(). It's contents are put into DownloadItem, and then only the download ID is passed around to get at the information.
In addition, most of DownloadItem's members are grouped into sub-structures by functionality:
- history_
Passed to the history data base, and includes the data relevant to that.
- request_
Contains the information about the request, which is not present in the other structures.
- state_
Contains data that is used to manage the download process. It is part of DownloadItem because it is specific to that item, but it could instead be passed around as an extra parameter.
Some notes on the refactoring:
- DownloadItem is only accessed in the UI thread. This means that the state_ structure needs to be passed by value to DownloadManager::CheckIfSuggestedPathExists(), modified there, and then passed by value again to DownloadManager::OnPathExistenceAvailable(), where it is copied bach into DownloadItem.
BUG=78084,77188
TEST=Passes all download unit tests.
Review URL: http://codereview.chromium.org/6969009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86319 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index fb25d3d..cb8611f 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -792,6 +792,8 @@ 'browser/dom_operation_notification_details.h', 'browser/download/base_file.cc', 'browser/download/base_file.h', + 'browser/download/download_create_info.cc', + 'browser/download/download_create_info.h', 'browser/download/download_extensions.cc', 'browser/download/download_extensions.h', 'browser/download/download_file.cc', @@ -820,6 +822,8 @@ 'browser/download/download_shelf_context_menu.cc', 'browser/download/download_shelf_context_menu.h', 'browser/download/download_started_animation.h', + 'browser/download/download_state_info.cc', + 'browser/download/download_state_info.h', 'browser/download/download_status_updater.cc', 'browser/download/download_status_updater.h', 'browser/download/download_status_updater_delegate.h', @@ -1136,10 +1140,10 @@ 'browser/hang_monitor/hung_window_detector.h', 'browser/history/archived_database.cc', 'browser/history/archived_database.h', - 'browser/history/download_create_info.cc', - 'browser/history/download_create_info.h', 'browser/history/download_database.cc', 'browser/history/download_database.h', + 'browser/history/download_history_info.cc', + 'browser/history/download_history_info.h', 'browser/history/expire_history_backend.cc', 'browser/history/expire_history_backend.h', 'browser/history/history.cc', |