diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-12 04:24:08 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-12 04:24:08 +0000 |
commit | 8ebfa3b67a5d756c9fba7f4f4925dd0c30d16e58 (patch) | |
tree | 91f07b26d01569dbc07f00ced3ca45ed3e9e959c /chrome/chrome_browser.gypi | |
parent | 8b6b3cf3e623d8f48069aa30a23bca58852d0b36 (diff) | |
download | chromium_src-8ebfa3b67a5d756c9fba7f4f4925dd0c30d16e58.zip chromium_src-8ebfa3b67a5d756c9fba7f4f4925dd0c30d16e58.tar.gz chromium_src-8ebfa3b67a5d756c9fba7f4f4925dd0c30d16e58.tar.bz2 |
Autofill dialog for the Mac. This is UI only at this point. The UI is not hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
-rwxr-xr-x | chrome/chrome_browser.gypi | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index fea9d48..109b503 100755 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -86,8 +86,18 @@ 'browser/autofill/address_field.h', 'browser/autofill/address.cc', 'browser/autofill/address.h', + 'browser/autofill/autofill_address_model_mac.h', + 'browser/autofill/autofill_address_model_mac.mm', + 'browser/autofill/autofill_address_view_controller_mac.h', + 'browser/autofill/autofill_address_view_controller_mac.mm', + 'browser/autofill/autofill_credit_card_model_mac.h', + 'browser/autofill/autofill_credit_card_model_mac.mm', + 'browser/autofill/autofill_credit_card_view_controller_mac.h', + 'browser/autofill/autofill_credit_card_view_controller_mac.mm', + 'browser/autofill/autofill_dialog_controller_mac.h', + 'browser/autofill/autofill_dialog_controller_mac.mm', 'browser/autofill/autofill_dialog_gtk.cc', - 'browser/autofill/autofill_dialog.cc', + 'browser/autofill/autofill_dialog_mac.mm', # Windows version of autofill dialog is defined in # 'browser/views/autofill_profiles_view_win.cc' 'browser/autofill/autofill_dialog.h', @@ -455,6 +465,8 @@ 'browser/cocoa/custom_home_pages_model.mm', 'browser/cocoa/delayedmenu_button.h', 'browser/cocoa/delayedmenu_button.mm', + 'browser/cocoa/disclosure_view_controller.h', + 'browser/cocoa/disclosure_view_controller.mm', 'browser/cocoa/dock_icon.h', 'browser/cocoa/dock_icon.mm', 'browser/cocoa/download_item_button.h', @@ -609,6 +621,8 @@ 'browser/cocoa/scoped_authorizationref.h', 'browser/cocoa/search_engine_list_model.h', 'browser/cocoa/search_engine_list_model.mm', + 'browser/cocoa/section_separator_view.h', + 'browser/cocoa/section_separator_view.mm', 'browser/cocoa/shell_dialogs_mac.mm', 'browser/cocoa/status_bubble_mac.h', 'browser/cocoa/status_bubble_mac.mm', @@ -648,6 +662,8 @@ 'browser/cocoa/ui_localizer.mm', 'browser/cocoa/url_drop_target.h', 'browser/cocoa/url_drop_target.mm', + 'browser/cocoa/vertical_layout_view.h', + 'browser/cocoa/vertical_layout_view.mm', 'browser/cocoa/view_resizer.h', 'browser/cocoa/web_drag_source.h', 'browser/cocoa/web_drag_source.mm', @@ -2290,6 +2306,9 @@ 'xib_files_to_scan': [ # The xibs that need localization 'app/nibs/About.xib', + 'app/nibs/AutoFillAddressFormView.xib', + 'app/nibs/AutoFillCreditCardFormView.xib', + 'app/nibs/AutoFillDialog.xib', 'app/nibs/BookmarkAllTabs.xib', 'app/nibs/BookmarkBar.xib', 'app/nibs/BookmarkBubble.xib', |