diff options
| author | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 17:47:01 +0000 |
|---|---|---|
| committer | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 17:47:01 +0000 |
| commit | b96f34ad357b1639f382c3764d9426efec4b2a52 (patch) | |
| tree | 5b81b22737f0fac98bb260c886f67d4a809b71c0 /chrome/chrome_browser.gypi | |
| parent | 145c762733827644c5e871c4357f6760f9a1a21e (diff) | |
| download | chromium_src-b96f34ad357b1639f382c3764d9426efec4b2a52.zip chromium_src-b96f34ad357b1639f382c3764d9426efec4b2a52.tar.gz chromium_src-b96f34ad357b1639f382c3764d9426efec4b2a52.tar.bz2 | |
Polish ChromeOS options dialog:
- Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow
so that it has a frame; This piece of code is based on Chrome's
OptionsWindowView. Ideally, we should use Chrome's options view but
we still missing underlying controls such as Tree and Table.
- Use last active browser window as options dialog's parent;
This makes optiosn dialog transient for the browser window and window
manager will no longer treat it as top-level window and will not move
and resize it;
- If user switches to a new browser window and invokes options dialog again,
close the existing one and re-opens it for the current browser window.
This is currently supported by window manager;
- Update CustomerFrameView and WindowDelegate to make client edge optionaly;
Options dialog has no client area padding and does not have a client
edge per UI mock;
- Make NativeViewHost respects its background. This solves the problem that
tab pane background is not properly cleared when hosting a native GtkVBox
pane in TabbedPane;
BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings
Review URL: http://codereview.chromium.org/1672003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 08663f8..dfad823 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -408,8 +408,8 @@ 'browser/chromeos/login/rounded_rect_painter.cc', 'browser/chromeos/login/rounded_rect_painter.h', 'browser/chromeos/login/screen_observer.h', - 'browser/chromeos/login/update_screen.cc', - 'browser/chromeos/login/update_screen.h', + 'browser/chromeos/login/update_screen.cc', + 'browser/chromeos/login/update_screen.h', 'browser/chromeos/login/update_view.cc', 'browser/chromeos/login/update_view.h', 'browser/chromeos/login/user_controller.cc', @@ -438,6 +438,8 @@ 'browser/chromeos/options/language_hangul_config_view.h', 'browser/chromeos/options/network_config_view.cc', 'browser/chromeos/options/network_config_view.h', + 'browser/chromeos/options/options_window_view.cc', + 'browser/chromeos/options/options_window_view.h', 'browser/chromeos/options/settings_page_view.cc', 'browser/chromeos/options/settings_page_view.h', 'browser/chromeos/options/system_page_view.cc', |