diff options
| author | jyasskin@chromium.org <jyasskin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-08 02:35:53 +0000 |
|---|---|---|
| committer | jyasskin@chromium.org <jyasskin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-08 02:35:53 +0000 |
| commit | f31d66db22527a49eaadf4e598f2e6976673bc48 (patch) | |
| tree | 76b54bde1da74a9be6574996319dadd41a461bae /chrome/chrome_browser_extensions.gypi | |
| parent | 7d6c372945b66064e03c794cfa3d22599da25c7b (diff) | |
| download | chromium_src-f31d66db22527a49eaadf4e598f2e6976673bc48.zip chromium_src-f31d66db22527a49eaadf4e598f2e6976673bc48.tar.gz chromium_src-f31d66db22527a49eaadf4e598f2e6976673bc48.tar.bz2 | |
Revert 216345 "Move ExtensionError to extensions/, add error limits"
It leaks memory:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/24926/steps/memory%20test%3A%20unit/logs/stdio
Leak_DefinitelyLost
663 (264 direct, 399 indirect) bytes in 3 blocks are definitely lost in loss record 33,024 of 38,445
operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140)
extensions::(anonymous namespace)::CreateNewRuntimeError(bool, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&) (chrome/browser/extensions/error_console/error_console_unittest.cc:51)
extensions::ErrorConsoleUnitTest_AddAndRemoveErrors_Test::TestBody() (chrome/browser/extensions/error_console/error_console_unittest.cc:80)
> Move ExtensionError to extensions/, add error limits
>
> Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
> Limit the number of errors stored per extension to 100.
> Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.
>
> BUG=21734
>
> Review URL: https://chromiumcodereview.appspot.com/21609003
TBR=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/22585003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser_extensions.gypi')
| -rw-r--r-- | chrome/chrome_browser_extensions.gypi | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/chrome_browser_extensions.gypi b/chrome/chrome_browser_extensions.gypi index 4ee3d38..6f7425d 100644 --- a/chrome/chrome_browser_extensions.gypi +++ b/chrome/chrome_browser_extensions.gypi @@ -54,8 +54,6 @@ # All .cc, .h, .m, and .mm files under browser/extensions except for # tests and mocks. '../extensions/browser/extension_prefs_scope.h', - '../extensions/browser/extension_error.cc', - '../extensions/browser/extension_error.h', '../extensions/browser/file_reader.cc', '../extensions/browser/file_reader.h', '../extensions/browser/pref_names.cc', @@ -575,6 +573,8 @@ 'browser/extensions/default_apps.h', 'browser/extensions/error_console/error_console.cc', 'browser/extensions/error_console/error_console.h', + 'browser/extensions/error_console/extension_error.cc', + 'browser/extensions/error_console/extension_error.h', 'browser/extensions/event_listener_map.cc', 'browser/extensions/event_listener_map.h', 'browser/extensions/event_names.cc', |