diff options
| author | andresantoso <andresantoso@chromium.org> | 2015-03-31 13:42:49 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-31 20:44:19 +0000 |
| commit | e0a3ce587eb395941ddb717e41c4b511ae452232 (patch) | |
| tree | fa71cd36a1b168383be20145bd931c7610568735 /chrome/chrome_browser_extensions.gypi | |
| parent | 9c524f0c7fdc20bec3fec8a2e3a779423e091782 (diff) | |
| download | chromium_src-e0a3ce587eb395941ddb717e41c4b511ae452232.zip chromium_src-e0a3ce587eb395941ddb717e41c4b511ae452232.tar.gz chromium_src-e0a3ce587eb395941ddb717e41c4b511ae452232.tar.bz2 | |
MacViews: Remove unused ExtensionViewHostMac
This code is problematic for MacViews browser, because it's Mac but does not
use the Cocoa popup controller.
This code was added to ExtensionHostMac http://crrev.com/1528006, to make
sure the extension's popup is closed when the extension's process is killed.
http://crrev.com/86363003 moved this code to ExtensionViewHostMac which has
different lifetime. Now when the process is killed,
-[ExtensionPopupController close] is invoked first before
~ExtensionViewHostMac, making this code unreachable.
BUG=425229
TEST=I modified ExtensionPopupController to not dismiss the popup when it
resigns key status, then used TaskManager to kill the extension's process and
confirmed that the popup disappears.
Review URL: https://codereview.chromium.org/1042543004
Cr-Commit-Position: refs/heads/master@{#323100}
Diffstat (limited to 'chrome/chrome_browser_extensions.gypi')
| -rw-r--r-- | chrome/chrome_browser_extensions.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/chrome_browser_extensions.gypi b/chrome/chrome_browser_extensions.gypi index 0e66f77..348ce04a 100644 --- a/chrome/chrome_browser_extensions.gypi +++ b/chrome/chrome_browser_extensions.gypi @@ -644,8 +644,6 @@ 'browser/extensions/extension_view_host.h', 'browser/extensions/extension_view_host_factory.cc', 'browser/extensions/extension_view_host_factory.h', - 'browser/extensions/extension_view_host_mac.h', - 'browser/extensions/extension_view_host_mac.mm', 'browser/extensions/extension_web_ui.cc', 'browser/extensions/extension_web_ui.h', 'browser/extensions/extension_web_ui_override_registrar.cc', |