diff options
| author | benm@chromium.org <benm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-12 21:24:07 +0000 |
|---|---|---|
| committer | benm@chromium.org <benm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-12 21:24:07 +0000 |
| commit | edc3af84cd907175e0dd24bfc377d20c06fd7d0e (patch) | |
| tree | a58d91856734a6001965ff8b111fc4a12f2c3b6e /chrome/chrome_browser_ui.gypi | |
| parent | c9e487a5cd3be915d23a1861f022223294be3fe9 (diff) | |
| download | chromium_src-edc3af84cd907175e0dd24bfc377d20c06fd7d0e.zip chromium_src-edc3af84cd907175e0dd24bfc377d20c06fd7d0e.tar.gz chromium_src-edc3af84cd907175e0dd24bfc377d20c06fd7d0e.tar.bz2 | |
Move form validation message bubble into content/, wire up to Android WebView.
At the moment, when form validation inside Blink fails (e.g. entering an invalid email address in an <input type=email />) we call out to chrome/ to show some UI to the user to indicate the error and give the opportunity to correct it.
This change moves the IPC to content/ (via RenderViewHost) and plumbs the validation handlers through WebContents and WebContentsDelegate. This gives content embedders the opportunity to receive the Blink callback.
There should be no behavior change; the implementation for showing the bubble on desktop platforms remains in the chrome/ layer. On Android it is moved into the WebContentsDelegateAndroid component such that Android WebView can share the code.
BUG=293608
R=jam@chromium.org, joi@chromium.org, joth@chromium.org, nasko@chromium.org, tkent@chromium.org
Review URL: https://codereview.chromium.org/23609053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240420 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser_ui.gypi')
| -rw-r--r-- | chrome/chrome_browser_ui.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi index 553309e..5fc645e 100644 --- a/chrome/chrome_browser_ui.gypi +++ b/chrome/chrome_browser_ui.gypi @@ -119,8 +119,6 @@ 'browser/ui/android/tab_model/tab_model_list.cc', 'browser/ui/android/tab_model/tab_model_list.h', 'browser/ui/android/tab_restore_service_delegate_android.cc', - 'browser/ui/android/validation_message_bubble_android.h', - 'browser/ui/android/validation_message_bubble_android.cc', 'browser/ui/android/website_settings_popup_android.cc', 'browser/ui/android/website_settings_popup_android.h', 'browser/ui/android/window_android_helper.cc', |