diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-09 18:42:00 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-09 18:42:00 +0000 |
| commit | 27b1d062fcc3a12fda87c6dddf43237ed9159ca5 (patch) | |
| tree | 2295dee443e148628a1203b0c7c9a1cd7cc4f0ed /chrome/chrome_exe.gypi | |
| parent | 06a45ebb1b65edfb84f96450ff34e4bac9fd550f (diff) | |
| download | chromium_src-27b1d062fcc3a12fda87c6dddf43237ed9159ca5.zip chromium_src-27b1d062fcc3a12fda87c6dddf43237ed9159ca5.tar.gz chromium_src-27b1d062fcc3a12fda87c6dddf43237ed9159ca5.tar.bz2 | |
Remove rendundant use of product_name in gyp files.
We default to using the target name as the product name;
there's no need to state it twice.
Review URL: http://codereview.chromium.org/7135006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88556 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_exe.gypi')
| -rw-r--r-- | chrome/chrome_exe.gypi | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 547d7bd..d336894 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -420,18 +420,14 @@ }], ['OS != "mac"', { 'conditions': [ - ['branding=="Chrome"', { - 'product_name': 'chrome' - }, { # else: Branding!="Chrome" - # TODO: change to: - # 'product_name': 'chromium' - # whenever we convert the rest of the infrastructure - # (buildbots etc.) to use "gyp -Dbranding=Chrome". - # NOTE: chrome/app/theme/chromium/BRANDING and - # chrome/app/theme/google_chrome/BRANDING have the short names, - # etc.; should we try to extract from there instead? - 'product_name': 'chrome' - }], + # TODO: add a: + # 'product_name': 'chromium' + # whenever we convert the rest of the infrastructure + # (buildbots etc.) to understand the branding gyp define. + # NOTE: chrome/app/theme/chromium/BRANDING and + # chrome/app/theme/google_chrome/BRANDING have the short name + # "chrome" etc.; should we try to extract from there instead? + # On Mac, this is done in chrome_dll.gypi. ['internal_pdf', { 'dependencies': [ |