Breakpad: Compile Breakpad into Chromium by default on Mac

This is intended to make it easier to test Breakpad crash dumping on
the buildbots.  Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.

The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.

This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler().  Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().

This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files.  This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.

BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
  should appear in ~/Library/Application Support/Chromium/Crash Reports


Review URL: http://codereview.chromium.org/8824003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 9 deletions

diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index cedc5b4..63af337 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -311,17 +311,18 @@
             {
               # Modify the Info.plist as needed.  The script explains why this
               # is needed.  This is also done in the helper_app and chrome_dll
-              # targets.  Use -b0 to not include any Breakpad information; that
-              # all goes into the framework's Info.plist.  Keystone information
-              # is included if Keystone is enabled.  The application reads
-              # Keystone keys from this plist and not the framework's, and
-              # the ticket will reference this Info.plist to determine the tag
-              # of the installed product.  Use -s1 to include Subversion
-              # information.  The -p flag controls whether to insert PDF as a
-              # supported type identifier that can be opened.
+              # targets.  Use --breakpad=0 to not include any Breakpad
+              # information; that all goes into the framework's Info.plist.
+              # Keystone information is included if Keystone is enabled.  The
+              # application reads Keystone keys from this plist and not the
+              # framework's, and the ticket will reference this Info.plist to
+              # determine the tag of the installed product.  Use -s1 to
+              # include Subversion information.  The -p flag controls whether
+              # to insert PDF as a supported type identifier that can be
+              # opened.
               'postbuild_name': 'Tweak Info.plist',
               'action': ['<(tweak_info_plist_path)',
-                         '-b0',
+                         '--breakpad=0',
                          '-k<(mac_keystone)',
                          '-s1',
                          '-p<(internal_pdf)',